From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Suppress EIO during set-to-cpu-domain
Date: Sat, 14 Apr 2012 23:24:30 +0100 [thread overview]
Message-ID: <1334442282_859@CP5-2952> (raw)
In-Reply-To: <20120414221615.GG4215@phenom.ffwll.local>
On Sun, 15 Apr 2012 00:16:15 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sat, Apr 14, 2012 at 10:24:21AM +0100, Chris Wilson wrote:
> > If the hardware is dead, we can simply discard any outstanding writes
> > from the GPU and presume the buffer is either in the GTT domain or
> > already in the CPU domain and continue on flushing the CPU caches.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Pardon my ignorance, but I fail to see the goal of these -EIO patches ...
> Care to mind the dense?
I encountered a page-fault-of-doom, due to i915_gem_fault() spinning on
a flush. i915_gem_reset() should fixup the buffers to prevent that.
However, I thought the EIO checks served as nice documentation along
paths that simply did not care why the GPU was no longer accessing the
buffer only that it wasn't.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-04-14 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 9:24 [PATCH] drm/i915: Suppress EIO during set-to-cpu-domain Chris Wilson
2012-04-14 22:16 ` Daniel Vetter
2012-04-14 22:24 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334442282_859@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.