Re: [PATCH 1/1] meta-yocto: Move OELAYOUT_ABI definition to poky.conf

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2012-04-16 at 12:26 -0400, Bob Cochran wrote:
> On 04/16/2012 03:52 AM, Dongxiao Xu wrote:
> > The ABI version definition should go along with the DISTRO variable
> > since it impact the TMPDIR definition.
> >
> > Otherwise, if a user used to work with pure OE-Core, and then he/she
> > added meta-yocto layer, it will report ABI version incompatibility
> > issue. This is because ABI is changed to "8" by adding meta-yocto layer,
> > however the DISTRO variable is not defined and TMPDIR is still
> > "tmp-eglibc".
> 
> I'm having trouble understanding what was accomplished with these 
> changes and the motivation for them.  Didn't poky do it's job of 
> complaining when the user first built without the meta-yocto layer and 
> then added it back in, which caused OELAYOUT_ABI to change?
> 
> Before and after the change, OELAYOUT_ABI="8" was defined in 
> meta-yocto/conf.  The setting of the variable was only moved between 
> files in this layer (abi_version.conf to poky.conf).    Regardless, 
> neither of these files are going to be found by the "include" inside 
> bitbake.conf once meta-yocto is removed from BBPATH.
> 
> When OELAYOUT_ABI was previously set in abi_version.conf, poky depended 
> on meta-yocto being in front of meta in BBPATH for the variable to be 
> picked up correctly, so it seems that moving the variable to poky.conf 
> and reordering the includes / requires in bitbake.conf removes the path 
> dependency, but I don't see this motivation anywhere in the commit 
> comments.
> 
> I'm certainly not a seasoned poky user, but it seems to me that this 
> change isn't explained well.
> 
> 
> >
> > Defining the OELAYOUT_ABI variable in poky.conf could fix this issue.
> >
> > This fixes [YOCTO #2303]
> 
> 
> Going into the bug description, it is stated in item #5 that the 
> meta-yocto layer was added back in, but it doesn't state whether DISTRO 
> was set again in local.conf to poky.  I'm thinking that was part of the 
> test procedure, but left out?
> 
> Any clarifications would be greatly appreciated.  Thanks!


The issue was that you could add the meta-yocto layer without setting
DISTRO="poky" but instead leave DISTRO unset. This would leave things in
an inconsistent state.

The change moves OELAYOUT_ABI alongside the change that uses it and
hence makes things consistent.

Cheers,

Richard