All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: David Miller <davem@davemloft.net>
Cc: meenakshi.venkataraman@intel.com, socketcan@hartkopp.net,
	linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, david.spinadel@intel.com
Subject: Re: net-next iwlwifi breaks compile - was Re: pull request: wireless-next 2012-04-18
Date: Thu, 19 Apr 2012 13:10:41 -0700	[thread overview]
Message-ID: <1334866241.27767.156.camel@wwguy-huron> (raw)
In-Reply-To: <20120419.154954.1322943404183128381.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

Hi David,


On Thu, 2012-04-19 at 15:49 -0400, David Miller wrote:
> From: "Venkataraman, Meenakshi" <meenakshi.venkataraman@intel.com>
> Date: Thu, 19 Apr 2012 19:47:58 +0000
> 
> > It was fixed internally in a subsequent patch, but that patch has
> > not made it into net-next. I don't see it in the public iwlwifi
> > repository either. We'll add the fix to the repository so you can
> > pick it up.
> 
> That's not how this works.
> 
> You should submit a patch to fix the build directly to me, immediately,
> so that I can push it directly into net-next as fast as possible.

The patch "iwlwifi-Remove-inconsistent-and-redundant-declaratio.patch"
already being push to John to address this issue

Thanks
Wey 

[-- Attachment #2: 0012-iwlwifi-Remove-inconsistent-and-redundant-declaratio.patch --]
[-- Type: text/x-patch, Size: 1264 bytes --]

>From c27cf685d185cc4604776252fdcaca5ad24abcca Mon Sep 17 00:00:00 2001
From: David Spinadel <david.spinadel@intel.com>
Date: Tue, 27 Mar 2012 10:22:29 +0200
Subject: [PATCH 12/15] iwlwifi: Remove inconsistent and redundant declaration

Remove declaration of iwl_alloc_traffic_mem from iwl-agn.h,
from methods that was exposed to support MVM.

MVM doesn't have to use this declaration.

Signed-off-by: David Spinadel <david.spinadel@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
---
 drivers/net/wireless/iwlwifi/iwl-agn.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.h b/drivers/net/wireless/iwlwifi/iwl-agn.h
index 67cd123..3d6f3e2 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.h
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.h
@@ -510,7 +510,6 @@ void iwl_setup_deferred_work(struct iwl_priv *priv);
 int iwl_send_wimax_coex(struct iwl_priv *priv);
 int iwl_send_bt_env(struct iwl_priv *priv, u8 action, u8 type);
 void iwl_debug_config(struct iwl_priv *priv);
-int iwl_alloc_traffic_mem(struct iwl_priv *priv);
 void iwl_set_hw_params(struct iwl_priv *priv);
 void iwl_init_context(struct iwl_priv *priv, u32 ucode_flags);
 int iwl_init_drv(struct iwl_priv *priv);
-- 
1.7.0.4


WARNING: multiple messages have this Message-ID (diff)
From: "Guy, Wey-Yi" <wey-yi.w.guy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: meenakshi.venkataraman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	socketcan-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org,
	linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	david.spinadel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: net-next iwlwifi breaks compile - was Re: pull request: wireless-next 2012-04-18
Date: Thu, 19 Apr 2012 13:10:41 -0700	[thread overview]
Message-ID: <1334866241.27767.156.camel@wwguy-huron> (raw)
In-Reply-To: <20120419.154954.1322943404183128381.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

Hi David,


On Thu, 2012-04-19 at 15:49 -0400, David Miller wrote:
> From: "Venkataraman, Meenakshi" <meenakshi.venkataraman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Date: Thu, 19 Apr 2012 19:47:58 +0000
> 
> > It was fixed internally in a subsequent patch, but that patch has
> > not made it into net-next. I don't see it in the public iwlwifi
> > repository either. We'll add the fix to the repository so you can
> > pick it up.
> 
> That's not how this works.
> 
> You should submit a patch to fix the build directly to me, immediately,
> so that I can push it directly into net-next as fast as possible.

The patch "iwlwifi-Remove-inconsistent-and-redundant-declaratio.patch"
already being push to John to address this issue

Thanks
Wey 

[-- Attachment #2: 0012-iwlwifi-Remove-inconsistent-and-redundant-declaratio.patch --]
[-- Type: text/x-patch, Size: 1354 bytes --]

>From c27cf685d185cc4604776252fdcaca5ad24abcca Mon Sep 17 00:00:00 2001
From: David Spinadel <david.spinadel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Date: Tue, 27 Mar 2012 10:22:29 +0200
Subject: [PATCH 12/15] iwlwifi: Remove inconsistent and redundant declaration

Remove declaration of iwl_alloc_traffic_mem from iwl-agn.h,
from methods that was exposed to support MVM.

MVM doesn't have to use this declaration.

Signed-off-by: David Spinadel <david.spinadel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/net/wireless/iwlwifi/iwl-agn.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.h b/drivers/net/wireless/iwlwifi/iwl-agn.h
index 67cd123..3d6f3e2 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.h
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.h
@@ -510,7 +510,6 @@ void iwl_setup_deferred_work(struct iwl_priv *priv);
 int iwl_send_wimax_coex(struct iwl_priv *priv);
 int iwl_send_bt_env(struct iwl_priv *priv, u8 action, u8 type);
 void iwl_debug_config(struct iwl_priv *priv);
-int iwl_alloc_traffic_mem(struct iwl_priv *priv);
 void iwl_set_hw_params(struct iwl_priv *priv);
 void iwl_init_context(struct iwl_priv *priv, u32 ucode_flags);
 int iwl_init_drv(struct iwl_priv *priv);
-- 
1.7.0.4


  reply	other threads:[~2012-04-19 20:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18 19:05 pull request: wireless-next 2012-04-18 John W. Linville
2012-04-18 19:05 ` John W. Linville
2012-04-18 19:36 ` David Miller
2012-04-19  4:49   ` net-next iwlwifi breaks compile - was " Oliver Hartkopp
2012-04-19  4:49     ` Oliver Hartkopp
2012-04-19 19:47     ` Venkataraman, Meenakshi
2012-04-19 19:47       ` Venkataraman, Meenakshi
2012-04-19 19:49       ` David Miller
2012-04-19 20:10         ` Guy, Wey-Yi [this message]
2012-04-19 20:10           ` Guy, Wey-Yi
2012-04-19 20:27           ` David Miller
2012-04-19 21:07         ` Venkataraman, Meenakshi
2012-04-20  5:18           ` Oliver Hartkopp
2012-04-20  5:18             ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334866241.27767.156.camel@wwguy-huron \
    --to=wey-yi.w.guy@intel.com \
    --cc=davem@davemloft.net \
    --cc=david.spinadel@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=meenakshi.venkataraman@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.