From: Chris Wilson <chris@chris-wilson.co.uk>
To: Adam Jackson <ajax@redhat.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/edid: Try harder to fix up base EDID blocks
Date: Tue, 24 Apr 2012 20:13:59 +0100 [thread overview]
Message-ID: <1335294871_40532@CP5-2952> (raw)
In-Reply-To: <1334587208-11772-1-git-send-email-ajax@redhat.com>
On Mon, 16 Apr 2012 10:40:08 -0400, Adam Jackson <ajax@redhat.com> wrote:
> Requiring the first byte of the EDID base block header to be 0 means we
> don't fix up as many transfer errors as we could. Instead have the
> callers specify whether it's meant to be block 0 or not, and
> conditionally run header fixup based on that.
>
> Bugzilla: https://bugzilla.redhat.com/812890
> Signed-off-by: Adam Jackson <ajax@redhat.com>
The patch does watch it says on the tin. I don't pretend to know how
frequent this corruption is, but as it stands the current code fails to
be as effective as it could be.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-04-24 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 14:40 [PATCH] drm/edid: Try harder to fix up base EDID blocks Adam Jackson
2012-04-24 18:56 ` Adam Jackson
2012-04-24 19:09 ` Alex Deucher
2012-04-24 19:13 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335294871_40532@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=ajax@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.