From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Ryan Wang <openspace.wang@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: 3.4-rc3 compile failed on IBM Power6
Date: Wed, 25 Apr 2012 14:10:42 +1000 [thread overview]
Message-ID: <1335327042.21961.27.camel@pasglop> (raw)
In-Reply-To: <20120425015044.GA4637@shangw>
On Wed, 2012-04-25 at 09:50 +0800, Gavin Shan wrote:
> In order to make iommu.c irrelative to CONFIG_EEH, we might figure out
> the PE number of the PCI device during PCI probe time. Here're some
> rough thoughts about the rework.
>
> - Introduce additional field "int pe_num" to "struct dev_archdata".
> That would be traced like: (struct pci_dev)->(struct device dev)
> ->(struct dev_archdata archdata).
> - During the PCI probe time (maybe pci_fixup_early), we can figure
> out the PE number.
>
> Then we can retrieve the PE number of PCI device from "int pe_num" and needn't
> care CONFIG_EEH has been turned on or off. I'm not sure Ben has any comments
> on the idea?
Just select EEH from pseries Kconfig, no point in keeping that a user visible option.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>,
Ryan Wang <openspace.wang@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: 3.4-rc3 compile failed on IBM Power6
Date: Wed, 25 Apr 2012 14:10:42 +1000 [thread overview]
Message-ID: <1335327042.21961.27.camel@pasglop> (raw)
In-Reply-To: <20120425015044.GA4637@shangw>
On Wed, 2012-04-25 at 09:50 +0800, Gavin Shan wrote:
> In order to make iommu.c irrelative to CONFIG_EEH, we might figure out
> the PE number of the PCI device during PCI probe time. Here're some
> rough thoughts about the rework.
>
> - Introduce additional field "int pe_num" to "struct dev_archdata".
> That would be traced like: (struct pci_dev)->(struct device dev)
> ->(struct dev_archdata archdata).
> - During the PCI probe time (maybe pci_fixup_early), we can figure
> out the PE number.
>
> Then we can retrieve the PE number of PCI device from "int pe_num" and needn't
> care CONFIG_EEH has been turned on or off. I'm not sure Ben has any comments
> on the idea?
Just select EEH from pseries Kconfig, no point in keeping that a user visible option.
Cheers,
Ben.
next prev parent reply other threads:[~2012-04-25 4:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 0:22 3.4-rc3 compile failed on IBM Power6 Ryan Wang
2012-04-25 0:54 ` Nishanth Aravamudan
2012-04-25 1:50 ` Gavin Shan
2012-04-25 1:50 ` Gavin Shan
2012-04-25 4:10 ` Benjamin Herrenschmidt [this message]
2012-04-25 4:10 ` Benjamin Herrenschmidt
2012-04-25 5:50 ` Gavin Shan
2012-04-25 5:50 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335327042.21961.27.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nacc@linux.vnet.ibm.com \
--cc=openspace.wang@gmail.com \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.