Re: [PATCH] ARM: OMAP3: gpmc: add BCH ecc api and modes

[Artem Bityutskiy <dedekind1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

On Tue, 2012-04-17 at 10:48 +0200, Ivan Djelic wrote:
> This patch adds a simple BCH ecc computation api, similar to the
> existing Hamming ecc api. It is intended to be used by the MTD layer.
> It implements the following features:
> 
> - support 4-bit and 8-bit ecc computation
> - do not protect user bytes in spare area, only data area is protected
> - ecc for an erased NAND page (0xFFs) is also a sequence of 0xFFs
> 
> This last feature is obtained by adding a constant polynomial to
> the hardware computed ecc. It allows to correct bitflips in blank pages
> and is extremely useful to support filesystems such as UBIFS, which expect
> erased pages to contain only 0xFFs.
> 
> This api has been tested on an OMAP3630 board.
> 
> Signed-off-by: Ivan Djelic <ivan.djelic@parrot.com>

Hi Tony,

what do you think about merging this patch? This is the enabler for
making UBIFS actually usable on OMAP platforms which use BCH ECC. There
are 2 other MTD patches which depend on this - so I wonder if it is
easier to merge this one via the MTD tree, providing it has your/others'
ack(s).

Thanks!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]