All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Paul Mackerras <paulus@samba.org>,
	Andreas Schwab <schwab@linux-m68k.org>,
	linuxppc-dev@lists.ozlabs.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tty/serial/pmac_zilog: Fix "nobody cared" IRQ message
Date: Mon, 30 Apr 2012 10:23:02 +1000	[thread overview]
Message-ID: <1335745382.20866.18.camel@pasglop> (raw)
In-Reply-To: <4F9C830D.8040906@lwfinger.net>

On Sat, 2012-04-28 at 18:53 -0500, Larry Finger wrote:

> 
> Index: wireless-testing/drivers/tty/serial/pmac_zilog.c
> ===================================================================
> --- wireless-testing.orig/drivers/tty/serial/pmac_zilog.c	2012-04-28 
> 15:51:38.843723074 -0500
> +++ wireless-testing/drivers/tty/serial/pmac_zilog.c	2012-04-28 
> 18:34:34.053900600 -0500

Patch seems to be wrapped... I'll apply manually this time around but
check your mailer settings :-)

Cheers,
Ben.

> @@ -469,7 +469,7 @@
>   	tty = NULL;
>   	if (r3 & (CHAEXT | CHATxIP | CHARxIP)) {
>   		if (!ZS_IS_OPEN(uap_a)) {
> -			pmz_debug("ChanA interrupt while open !\n");
> +			pmz_debug("ChanA interrupt while not open !\n");
>   			goto skip_a;
>   		}
>   		write_zsreg(uap_a, R0, RES_H_IUS);
> @@ -493,8 +493,8 @@
>   	spin_lock(&uap_b->port.lock);
>   	tty = NULL;
>   	if (r3 & (CHBEXT | CHBTxIP | CHBRxIP)) {
> -		if (!ZS_IS_OPEN(uap_a)) {
> -			pmz_debug("ChanB interrupt while open !\n");
> +		if (!ZS_IS_OPEN(uap_b)) {
> +			pmz_debug("ChanB interrupt while not open !\n");
>   			goto skip_b;
>   		}
>   		write_zsreg(uap_b, R0, RES_H_IUS);

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tty/serial/pmac_zilog: Fix "nobody cared" IRQ message
Date: Mon, 30 Apr 2012 10:23:02 +1000	[thread overview]
Message-ID: <1335745382.20866.18.camel@pasglop> (raw)
In-Reply-To: <4F9C830D.8040906@lwfinger.net>

On Sat, 2012-04-28 at 18:53 -0500, Larry Finger wrote:

> 
> Index: wireless-testing/drivers/tty/serial/pmac_zilog.c
> ===================================================================
> --- wireless-testing.orig/drivers/tty/serial/pmac_zilog.c	2012-04-28 
> 15:51:38.843723074 -0500
> +++ wireless-testing/drivers/tty/serial/pmac_zilog.c	2012-04-28 
> 18:34:34.053900600 -0500

Patch seems to be wrapped... I'll apply manually this time around but
check your mailer settings :-)

Cheers,
Ben.

> @@ -469,7 +469,7 @@
>   	tty = NULL;
>   	if (r3 & (CHAEXT | CHATxIP | CHARxIP)) {
>   		if (!ZS_IS_OPEN(uap_a)) {
> -			pmz_debug("ChanA interrupt while open !\n");
> +			pmz_debug("ChanA interrupt while not open !\n");
>   			goto skip_a;
>   		}
>   		write_zsreg(uap_a, R0, RES_H_IUS);
> @@ -493,8 +493,8 @@
>   	spin_lock(&uap_b->port.lock);
>   	tty = NULL;
>   	if (r3 & (CHBEXT | CHBTxIP | CHBRxIP)) {
> -		if (!ZS_IS_OPEN(uap_a)) {
> -			pmz_debug("ChanB interrupt while open !\n");
> +		if (!ZS_IS_OPEN(uap_b)) {
> +			pmz_debug("ChanB interrupt while not open !\n");
>   			goto skip_b;
>   		}
>   		write_zsreg(uap_b, R0, RES_H_IUS);



  parent reply	other threads:[~2012-04-30  0:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-28 23:53 [PATCH] tty/serial/pmac_zilog: Fix "nobody cared" IRQ message Larry Finger
2012-04-28 23:53 ` Larry Finger
2012-04-29  9:05 ` Gabriel Paubert
2012-04-29  9:05   ` Gabriel Paubert
2012-04-29 15:47   ` Larry Finger
2012-04-29 15:47     ` Larry Finger
2012-04-30  0:23 ` Benjamin Herrenschmidt [this message]
2012-04-30  0:23   ` Benjamin Herrenschmidt
2012-04-30  0:52   ` Larry Finger
2012-04-30  0:52     ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335745382.20866.18.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.