From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>
Subject: Re: [PATCH v3 09/10] mtd: nand: utilize oob_required parameter
Date: Tue, 01 May 2012 15:12:22 +0300 [thread overview]
Message-ID: <1335874342.2095.5.camel@koala> (raw)
In-Reply-To: <CAN8TOE80t39VYw328p1O8Hh6XdjGn5JLuG3ZftqH3e7u+JQp2Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Mon, 2012-04-30 at 14:49 -0700, Brian Norris wrote:
> On Mon, Apr 30, 2012 at 1:21 PM, Scott Wood <scottwood@freescale.com> wrote:
> > On 04/30/2012 02:59 PM, Brian Norris wrote:
> >> I see. This is the kind of issue I was alluding to back in v2:
> >>
> >> "For instance, is there any sort of hardware that expects the whole
> >> page + OOB to be read via chip->read_buf() for all reads..."
> >>
> >> This situation comes up if NAND_NO_AUTOINCR is not set. But really, it
> >> looks like we *always* have NAND_NO_AUTOINCR enabled, and so we
> >> *always* send a new READ cmd. I know that it's possible for some board
> >> driver to override this, but I don't see that anywhere...
> >
> > If it's never used, maybe just remove autoincrement support altogether
> > and simplify the code?
>
> Fine with me. I'd like some word from a Artem or David though.
My opinion is that we have too much cruft and killing unused feature is
fine.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-01 12:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 1:29 [PATCH v3 00/10] mtd: nand: rework nand_ecc_ctrl interface for OOB Brian Norris
2012-04-28 1:29 ` [PATCH v3 01/10] mtd: nand: add 'oob_required' argument to NAND {read, write}_page interfaces Brian Norris
2012-04-29 11:36 ` [PATCH v3 01/10] mtd: nand: add 'oob_required' argument to NAND {read,write}_page interfaces Shmulik Ladkani
2012-04-29 13:25 ` Artem Bityutskiy
2012-04-30 19:16 ` Brian Norris
2012-04-30 19:21 ` Scott Wood
2012-04-28 1:29 ` [PATCH v3 02/10] mtd: nand: pass proper 'oob_required' parameter Brian Norris
2012-04-29 11:41 ` Shmulik Ladkani
2012-04-28 1:29 ` [PATCH v3 03/10] mtd: Blackfin NFC: utilize oob_required parameter Brian Norris
2012-04-28 1:29 ` [PATCH v3 04/10] mtd: cafe_nand: " Brian Norris
2012-04-28 1:29 ` [PATCH v3 05/10] mtd: denali: " Brian Norris
2012-04-28 1:29 ` [PATCH v3 06/10] mtd: eLBD NAND: " Brian Norris
2012-04-28 1:29 ` [PATCH v3 07/10] mtd: IFC " Brian Norris
2012-04-30 16:43 ` Scott Wood
2012-04-30 19:08 ` Brian Norris
2012-04-30 19:13 ` Scott Wood
2012-04-30 19:23 ` Brian Norris
2012-04-30 19:32 ` Scott Wood
2012-04-28 1:29 ` [PATCH v3 08/10] mtd: gpmi-nand: utilize oob_requested parameter Brian Norris
2012-04-28 2:32 ` Huang Shijie
2012-04-28 1:29 ` [PATCH v3 09/10] mtd: nand: utilize oob_required parameter Brian Norris
2012-04-29 12:47 ` Shmulik Ladkani
2012-04-30 19:59 ` Brian Norris
2012-04-30 20:12 ` Brian Norris
2012-04-30 20:21 ` Scott Wood
2012-04-30 21:49 ` Brian Norris
2012-05-01 12:12 ` Artem Bityutskiy [this message]
2012-05-01 8:29 ` Shmulik Ladkani
2012-04-28 1:29 ` [PATCH v3 10/10] mtd: pxa3xx_nand: " Brian Norris
2012-04-30 7:10 ` [PATCH v3 00/10] mtd: nand: rework nand_ecc_ctrl interface for OOB Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335874342.2095.5.camel@koala \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=scottwood@freescale.com \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.