Re: [PATCH v3 01/10] mtd: nand: add 'oob_required' argument to NAND {read,write}_page interfaces

[Scott Wood <scottwood@freescale.com>]

On 04/30/2012 02:16 PM, Brian Norris wrote:
> On Sun, Apr 29, 2012 at 6:25 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
>> On Sun, 2012-04-29 at 14:36 +0300, Shmulik Ladkani wrote:
>>>> Note: I couldn't compile-test all of these easily, as some had ARCH
>>>> dependencies.
>>>>
>>>> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>>>
>>> Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>>
>> Brian, probably you take care of this, but just in case I would like to
>> ask to put tags like this to your patches when re-sending. I am trying
>> to be careful about this for several reasons: it shows that the patch
>> was reviewed, it saves the reviewers name in the git history which and
>> makes persons' contribution visible, so it is kind of a credit.
> 
> Sure, I'll do this as appropriate. Should I apply these tags when the
> review is made w/o an explicit "Reviewed-by" (e.g., Scott Wood's
> comments on patch 7)? There's also the issue of placing "reviewed-by"
> before the reviewer actually sees my change.

You can put mine on if you want in this case, provided the write-side
change is removed as discussed -- but in general, I'd say that making a
comment on one part of a patch doesn't indicate that the whole thing has
been reviewed.

-Scott