Re: [PATCH v3 0/10] sh_flctl hardware ECC mode cleanup

[Artem Bityutskiy <dedekind1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3335 bytes --]

On Wed, 2012-05-02 at 13:51 +0200, Bastian Hecht wrote:
> Hi Artem,
> 
> 2012/5/2 Artem Bityutskiy <dedekind1@gmail.com>:
> > On Wed, 2012-05-02 at 11:41 +0200, Bastian Hecht wrote:
> >> changelog v3:
> >>
> >> Just a rebase on current l2-mtd.git.
> >
> > Aiaiai says that your patch-set introduced several warnings, could you
> > please take a look:
> >
> > --------------------------------------------------------------------------------
> >
> > Bisectability test results for configuration "l2_mackerel_defconfig,arm,arm-unknown-linux-gnueabi-"
> >
> > Bisecability test passed
> >
> > --------------------------------------------------------------------------------
> >
> > Successfully built configuration "l2_mackerel_defconfig,arm,arm-unknown-linux-gnueabi-", results:
> >
> > --- before_patching.log
> > +++ after_patching.log
> > @@ @@
> > -drivers/mtd/nand/sh_flctl.c:264:30: warning: incorrect type in argument 1 (different address spaces) [sparse]
> > -drivers/mtd/nand/sh_flctl.c:264:30:    expected void const volatile [noderef] <asn:2>*<noident> [sparse]
> > -drivers/mtd/nand/sh_flctl.c:264:30:    got void *fifo_addr [sparse]
> > +drivers/mtd/nand/sh_flctl.c:301:38: warning: incorrect type in argument 1 (different address spaces) [sparse]
> > +drivers/mtd/nand/sh_flctl.c:301:38:    expected void const volatile [noderef] <asn:2>*<noident> [sparse]
> > +drivers/mtd/nand/sh_flctl.c:301:38:    got void *fifo_addr [sparse]
> > +drivers/mtd/nand/sh_flctl.c:326:28: warning: cast removes address space of expression [sparse]
> > +drivers/mtd/nand/sh_flctl.c:331:17: warning: incorrect type in argument 1 (different address spaces) [sparse]
> > +drivers/mtd/nand/sh_flctl.c:331:17:    expected void const volatile [noderef] <asn:2>*<noident> [sparse]
> > +drivers/mtd/nand/sh_flctl.c:331:17:    got void *fifo_addr [sparse]
> > +drivers/mtd/nand/sh_flctl.c:967 flctl_probe() warn: 'irq' was not released on error [smatch]
> >
> > --------------------------------------------------------------------------------
> 
> Nice! Every day I learn about a new tool for kernel developing. I
> cloned your aiaiai tree but am unsure how to run it as
> CONFIG_MTD_NAND_SH_FLCTL is not set in the mackerel_defconfig. Can you
> supply me with a command line how you tested it?

For the trees I maintain I have this repository:

git://git.infradead.org/users/dedekind/maintaining.git

where I store various helper scripts. To test your patch-set I used
"l2-mtd-sh_flctl.sh" script, I run it like this:

../aiaiai/concat-mbox-files ~/tmp/bastian* | ./l2-mtd-general.sh

where ../aiaiai is a clone of aiaiai repository:

git://git.infradead.org/users/dedekind/aiaiai.git

and the concat-mbox-files is a helper script which concatenates several
mbox files. The ~/tmp/bastian* are your patches saved as mbox.

Those helper scripts require you to clone the l2-mtd.git tree and
checkout the "defconfigs" branch which contains the
'l2_makerel_defconfig' configuration.

Aiaiai also needs several packages to be installed - see README file in
the aiaiai repo. It also needs smatch and sparse - also documented in
README. Sorry that this stuff is not too user-friendly - I do not have
time to clean it up.

Feel free to ask for help.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]