From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
MIPS Mailing List <linux-mips@linux-mips.org>,
MTD Maling List <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 2/2] MIPS: bcm63xx: kbuild: remove -Werror
Date: Sun, 06 May 2012 10:36:59 +0300 [thread overview]
Message-ID: <1336289819.1996.5.camel@koala> (raw)
In-Reply-To: <alpine.LFD.2.00.1205060804400.19691@eddie.linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
On Sun, 2012-05-06 at 08:06 +0100, Maciej W. Rozycki wrote:
> On Fri, 27 Apr 2012, Artem Bityutskiy wrote:
>
> > From: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
> >
> > I cannot build bcm963xx with the standard Kbuild W=1 switch:
> >
> > arch/mips/bcm63xx/boards/board_bcm963xx.c: At top level:
> > arch/mips/bcm63xx/boards/board_bcm963xx.c:647:5: error: no previous prototype for 'bcm63xx_get_fallback_sprom' [-Werror=missing-prototypes]
> > cc1: all warnings being treated as errors
> >
> > This patch removes the gcc switch to make W=1 work. Mips is the only
> > architecture I know which does not build with W=1 and this upsets my aiaiai
> > scripts. And in general, you never know which warnings newer versions of gcc
> > will start emiting so having -Werror by default is not the best idea.
>
> If the function has no prototype, then it cannot be reasonably used from
> outside -- perhaps you meant to mark it static instead?
No, I meant what I meant - MIPS does not build with W=1.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: MIPS Mailing List <linux-mips@linux-mips.org>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 2/2] MIPS: bcm63xx: kbuild: remove -Werror
Date: Sun, 06 May 2012 10:36:59 +0300 [thread overview]
Message-ID: <1336289819.1996.5.camel@koala> (raw)
In-Reply-To: <alpine.LFD.2.00.1205060804400.19691@eddie.linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
On Sun, 2012-05-06 at 08:06 +0100, Maciej W. Rozycki wrote:
> On Fri, 27 Apr 2012, Artem Bityutskiy wrote:
>
> > From: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
> >
> > I cannot build bcm963xx with the standard Kbuild W=1 switch:
> >
> > arch/mips/bcm63xx/boards/board_bcm963xx.c: At top level:
> > arch/mips/bcm63xx/boards/board_bcm963xx.c:647:5: error: no previous prototype for 'bcm63xx_get_fallback_sprom' [-Werror=missing-prototypes]
> > cc1: all warnings being treated as errors
> >
> > This patch removes the gcc switch to make W=1 work. Mips is the only
> > architecture I know which does not build with W=1 and this upsets my aiaiai
> > scripts. And in general, you never know which warnings newer versions of gcc
> > will start emiting so having -Werror by default is not the best idea.
>
> If the function has no prototype, then it cannot be reasonably used from
> outside -- perhaps you meant to mark it static instead?
No, I meant what I meant - MIPS does not build with W=1.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-06 7:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 13:48 [PATCH 1/2] MIPS: Kbuild: remove -Werror Artem Bityutskiy
2012-04-27 13:48 ` [PATCH 2/2] MIPS: bcm63xx: kbuild: " Artem Bityutskiy
2012-05-06 7:06 ` Maciej W. Rozycki
2012-05-06 7:06 ` Maciej W. Rozycki
2012-05-06 7:36 ` Artem Bityutskiy [this message]
2012-05-06 7:36 ` Artem Bityutskiy
2012-05-21 18:15 ` Ralf Baechle
2012-04-27 17:03 ` [PATCH 1/2] MIPS: Kbuild: " David Daney
2012-05-06 7:04 ` Maciej W. Rozycki
2012-05-06 7:04 ` Maciej W. Rozycki
2012-05-06 7:34 ` Artem Bityutskiy
2012-05-06 7:34 ` Artem Bityutskiy
2012-05-06 8:32 ` Maciej W. Rozycki
2012-05-06 8:32 ` Maciej W. Rozycki
2012-05-06 8:37 ` Artem Bityutskiy
2012-05-06 8:37 ` Artem Bityutskiy
2012-05-06 9:14 ` Maciej W. Rozycki
2012-05-06 9:14 ` Maciej W. Rozycki
2012-05-13 12:08 ` Jonas Gorski
2012-05-13 12:08 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336289819.1996.5.camel@koala \
--to=dedekind1@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.