Re: [PATCH 1/1] pango: Fix modules load failure in multilib environment

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2012-05-07 at 08:55 +0800, Zhai, Edwin wrote:
> On 05/06/2012 04:48 PM, Richard Purdie wrote:
> > There is a missing FILES_${PN}-dbg += "${bindir}/${baselib}/.debug".
> >
> > I am left wondering if we would be better doing something like:
> >
> > do_install_append () {
> > 	if [ "${MLPREFIX}" != "" ]; then
> > 		mv ${bindir}/pango-querymodules ${bindir}/${MLPREFIX}pango-querymodules
> > 	fi
> > }
> 
> Does it makes others hard to find the util if changing the name?
> 
> >
> > It would also be worth cosidering if the patch would be any neater if we
> > pass ${MLPREFIX} in as an extra variable?
> 
> Change the pango-querymodules command line to accept an extra parameter 
> to indicate where to query? I can have a check to see if it works.
>
> Regarding the lib, the path is hard coded, so we can't pass ${MLPREFIX} in.

Sorry, I meant pass in ${MLPREFIX} as an option to configure so it would
be compiled in.

Cheers,

Richard