From: "Zhai, Edwin" <edwin.zhai@intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] pango: Fix modules load failure in multilib environment
Date: Mon, 07 May 2012 08:55:46 +0800 [thread overview]
Message-ID: <4FA71D92.4060704@intel.com> (raw)
In-Reply-To: <1336294096.23777.55.camel@ted>
On 05/06/2012 04:48 PM, Richard Purdie wrote:
> There is a missing FILES_${PN}-dbg += "${bindir}/${baselib}/.debug".
>
> I am left wondering if we would be better doing something like:
>
> do_install_append () {
> if [ "${MLPREFIX}" != "" ]; then
> mv ${bindir}/pango-querymodules ${bindir}/${MLPREFIX}pango-querymodules
> fi
> }
Does it makes others hard to find the util if changing the name?
>
> It would also be worth cosidering if the patch would be any neater if we
> pass ${MLPREFIX} in as an extra variable?
Change the pango-querymodules command line to accept an extra parameter
to indicate where to query? I can have a check to see if it works.
Regarding the lib, the path is hard coded, so we can't pass ${MLPREFIX} in.
>
> Cheers,
>
> Richard
next prev parent reply other threads:[~2012-05-07 0:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 7:43 [PATCH 0/1] Fix pango modules load failure in multilib environment, Edwin, May2, 2012 edwin.zhai
2012-05-02 7:43 ` [PATCH 1/1] pango: Fix modules load failure in multilib environment edwin.zhai
2012-05-04 18:11 ` [poky] " Scott Garman
2012-05-05 3:58 ` Saul Wold
2012-05-06 8:48 ` Richard Purdie
2012-05-07 0:55 ` Zhai, Edwin [this message]
2012-05-07 8:06 ` Richard Purdie
-- strict thread matches above, loose matches on Subject: below --
2012-05-08 14:43 [PATCH 0/1][V2] Fix pango modules load failure in multilib environment, Edwin, May8, 2012 edwin.zhai
2012-05-08 14:43 ` [PATCH 1/1] pango: Fix modules load failure in multilib environment edwin.zhai
2012-05-08 15:18 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA71D92.4060704@intel.com \
--to=edwin.zhai@intel.com \
--cc=poky@yoctoproject.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.