All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/radeon/kms: fix warning on 32-bit in atomic fence printing
@ 2012-05-09 16:28 Dave Airlie
  2012-05-09 16:57 ` Jerome Glisse
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Airlie @ 2012-05-09 16:28 UTC (permalink / raw)
  To: dri-devel

From: Dave Airlie <airlied@redhat.com>

/ssd/git/drm-core-next/drivers/gpu/drm/radeon/radeon_fence.c: In function ‘radeon_debugfs_fence_info’:
/ssd/git/drm-core-next/drivers/gpu/drm/radeon/radeon_fence.c:606:7: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘long long int’ [-Wformat]

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/radeon/radeon_fence.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon/radeon_fence.c
index 48ec5e3..11f5f40 100644
--- a/drivers/gpu/drm/radeon/radeon_fence.c
+++ b/drivers/gpu/drm/radeon/radeon_fence.c
@@ -602,8 +602,8 @@ static int radeon_debugfs_fence_info(struct seq_file *m, void *data)
 			continue;
 
 		seq_printf(m, "--- ring %d ---\n", i);
-		seq_printf(m, "Last signaled fence 0x%016lx\n",
-			   atomic64_read(&rdev->fence_drv[i].last_seq));
+		seq_printf(m, "Last signaled fence 0x%016llx\n",
+			   (unsigned long long)atomic64_read(&rdev->fence_drv[i].last_seq));
 		seq_printf(m, "Last emitted  0x%016llx\n",
 			   rdev->fence_drv[i].seq);
 	}
-- 
1.7.7.6

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/radeon/kms: fix warning on 32-bit in atomic fence printing
  2012-05-09 16:28 [PATCH] drm/radeon/kms: fix warning on 32-bit in atomic fence printing Dave Airlie
@ 2012-05-09 16:57 ` Jerome Glisse
  0 siblings, 0 replies; 2+ messages in thread
From: Jerome Glisse @ 2012-05-09 16:57 UTC (permalink / raw)
  To: Dave Airlie; +Cc: dri-devel

On Wed, May 9, 2012 at 12:28 PM, Dave Airlie <airlied@gmail.com> wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> /ssd/git/drm-core-next/drivers/gpu/drm/radeon/radeon_fence.c: In function ‘radeon_debugfs_fence_info’:
> /ssd/git/drm-core-next/drivers/gpu/drm/radeon/radeon_fence.c:606:7: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘long long int’ [-Wformat]
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>

Reviewed-by: Jerome Glisse <jglisse@redhat.com>

> ---
>  drivers/gpu/drm/radeon/radeon_fence.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon/radeon_fence.c
> index 48ec5e3..11f5f40 100644
> --- a/drivers/gpu/drm/radeon/radeon_fence.c
> +++ b/drivers/gpu/drm/radeon/radeon_fence.c
> @@ -602,8 +602,8 @@ static int radeon_debugfs_fence_info(struct seq_file *m, void *data)
>                        continue;
>
>                seq_printf(m, "--- ring %d ---\n", i);
> -               seq_printf(m, "Last signaled fence 0x%016lx\n",
> -                          atomic64_read(&rdev->fence_drv[i].last_seq));
> +               seq_printf(m, "Last signaled fence 0x%016llx\n",
> +                          (unsigned long long)atomic64_read(&rdev->fence_drv[i].last_seq));
>                seq_printf(m, "Last emitted  0x%016llx\n",
>                           rdev->fence_drv[i].seq);
>        }
> --
> 1.7.7.6
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-09 16:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-09 16:28 [PATCH] drm/radeon/kms: fix warning on 32-bit in atomic fence printing Dave Airlie
2012-05-09 16:57 ` Jerome Glisse

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.