From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Introduce for_each_ring() macro
Date: Fri, 11 May 2012 00:18:05 +0100 [thread overview]
Message-ID: <1336691906_233174@CP5-2952> (raw)
In-Reply-To: <20120510153932.00012f65@bwidawsk.net>
On Thu, 10 May 2012 15:39:32 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> I'm not opposed to this change, but it would have probably been better
> to not remove the BUG_ONs.
I actually removed them because in order to satisfy them we have to
initialise rings we never use (and have another patch so that we only
intialise rings once inside intel_ringbuffer.c). We were causing extra
work for ourselves for no good reason.
And we need to cull the BUG_ONs for which a WARN and recovery would
serve better.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-05-10 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:27 [PATCH] drm/i915: Introduce for_each_ring() macro Chris Wilson
2012-05-10 21:21 ` Chris Wilson
2012-05-10 22:39 ` Ben Widawsky
2012-05-10 23:18 ` Chris Wilson [this message]
2012-05-11 9:00 ` Daniel Vetter
2012-05-11 9:26 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336691906_233174@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.