All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Replace the feature tests for BLT/BSD with ring init checks
Date: Fri, 11 May 2012 21:24:06 +0100	[thread overview]
Message-ID: <1336767866_248148@CP5-2952> (raw)
In-Reply-To: <20120511125814.14d997b3@bwidawsk.net>

On Fri, 11 May 2012 12:58:14 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Fri, 11 May 2012 14:29:32 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
> 
> > When userspace asks whether the driver supports the BLT or BSD rings for
> > this chip, simply report whether those particular rings are initialised
> > 
> 
> This was the one place where I felt HAS_BLT and HAS_BSD was sort of
> nice to keep around to distinguish HW has the ring vs. HW successfully
> initialized the rings.

The hw supporting those rings is useless if the driver doesn't, imo.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2012-05-11 20:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 13:29 [PATCH 1/3] drm/i915: Introduce for_each_ring() macro Chris Wilson
2012-05-11 13:29 ` [PATCH 2/3] drm/i915: Check whether the ring is initialised prior to dispatch Chris Wilson
2012-05-11 19:53   ` Ben Widawsky
2012-05-11 13:29 ` [PATCH 3/3] drm/i915: Replace the feature tests for BLT/BSD with ring init checks Chris Wilson
2012-05-11 19:58   ` Ben Widawsky
2012-05-11 20:24     ` Chris Wilson [this message]
2012-05-11 19:46 ` [PATCH 1/3] drm/i915: Introduce for_each_ring() macro Ben Widawsky
2012-05-13 13:35   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336767866_248148@CP5-2952 \
    --to=chris@chris-wilson.co.uk \
    --cc=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.