From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>,
Eugeni Dodonov <eugeni@dodonov.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Enable the PCH PLL for all generations after link training
Date: Sun, 13 May 2012 15:25:10 +0100 [thread overview]
Message-ID: <1336919135_5662@CP5-2952> (raw)
In-Reply-To: <20120513140832.GE4720@phenom.ffwll.local>
On Sun, 13 May 2012 16:08:32 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sun, May 13, 2012 at 09:54:09AM +0100, Chris Wilson wrote:
> > Hidden away within one chipset specific path was the necessary logic to
> > turn on the PLL. This needs to be done everywhere in order for us to
> > drive any display! As such as soon as we tested on a non-CougarPoint
> > chipset, we failed to bring up any DisplayPorts and generated a nice set
> > of assertion failures in the process. At least one part of our logic is
> > working, the part that assumes that we have no idea what we are doing.
> >
> > Reported-by: guang.a.yang@intel.com
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=49712
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> I guess as-is this patch will blow up on hsw. I think we need to change
> the BUG_ON(!pll) in there into a return, like in the disable code. Eugeni?
Whoops, should have looked harder. My thinking was that on hsw, the pll
would be NULL and so the routine would have no effect. Tricksy BUG_ON.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-05-13 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 8:54 [PATCH 1/2] drm/i915: Convert BUG_ON(!pll->active) to a WARN Chris Wilson
2012-05-13 8:54 ` [PATCH 2/2] drm/i915: Enable the PCH PLL for all generations after link training Chris Wilson
2012-05-13 14:08 ` Daniel Vetter
2012-05-13 14:25 ` Chris Wilson [this message]
2012-05-13 23:35 ` Eugeni Dodonov
2012-05-13 23:39 ` Eugeni Dodonov
2012-05-14 15:12 ` Jesse Barnes
2012-05-14 15:23 ` Chris Wilson
2012-05-13 13:42 ` [PATCH 1/2] drm/i915: Convert BUG_ON(!pll->active) to a WARN Daniel Vetter
2012-05-13 19:16 ` [PATCH] drm/i915: Convert BUG_ON(!pll->active) and friends " Chris Wilson
2012-05-13 20:08 ` Daniel Vetter
2012-05-13 20:15 ` Chris Wilson
2012-05-19 21:11 ` Daniel Vetter
2012-05-13 23:51 ` Eugeni Dodonov
2012-05-19 21:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336919135_5662@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=eugeni@dodonov.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.