From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Enable the PCH PLL for all generations after link training
Date: Mon, 14 May 2012 16:23:05 +0100 [thread overview]
Message-ID: <1337008989_24144@CP5-2952> (raw)
In-Reply-To: <20120514081213.76b208cb@jbarnes-desktop>
On Mon, 14 May 2012 08:12:13 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> Thanks Chris. Only thing I'm not sure about is the LPT bit; does this
> function do what we want there?
The other patch transforms intel_pch_enable_pll (hmm, that's actually
a better name ;-) into a no-op if the crtc does not require a pll. Which
I think is the easier way of tracking PLLs - allocate on up front if the
chipset/output requires a PLL and then we do no need any more checks
other than has-pll? in the main body of the code.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-05-14 15:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 8:54 [PATCH 1/2] drm/i915: Convert BUG_ON(!pll->active) to a WARN Chris Wilson
2012-05-13 8:54 ` [PATCH 2/2] drm/i915: Enable the PCH PLL for all generations after link training Chris Wilson
2012-05-13 14:08 ` Daniel Vetter
2012-05-13 14:25 ` Chris Wilson
2012-05-13 23:35 ` Eugeni Dodonov
2012-05-13 23:39 ` Eugeni Dodonov
2012-05-14 15:12 ` Jesse Barnes
2012-05-14 15:23 ` Chris Wilson [this message]
2012-05-13 13:42 ` [PATCH 1/2] drm/i915: Convert BUG_ON(!pll->active) to a WARN Daniel Vetter
2012-05-13 19:16 ` [PATCH] drm/i915: Convert BUG_ON(!pll->active) and friends " Chris Wilson
2012-05-13 20:08 ` Daniel Vetter
2012-05-13 20:15 ` Chris Wilson
2012-05-19 21:11 ` Daniel Vetter
2012-05-13 23:51 ` Eugeni Dodonov
2012-05-19 21:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337008989_24144@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.