From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: tglx@linutronix.de, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] UBI: Kill data type hint
Date: Sun, 13 May 2012 17:26:06 +0300 [thread overview]
Message-ID: <1336919166.2003.7.camel@koala> (raw)
In-Reply-To: <1336738443-112022-1-git-send-email-richard@nod.at>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Fri, 2012-05-11 at 14:14 +0200, Richard Weinberger wrote:
> Artem,
>
> Do you want this change as singe patch or shall I split it up?
> For now I made it as single patch to avoid build errors while
> bisecting.
Hi Richard,
I'd like to merge it to 3.5, so making it easier to review would be
great. Could you please do split it at least on 2 patches, may be even
thee:
1. Remove the function arguments dtype also in comments to these
functions. This should be the largest patch, but should be no-brainer.
2. Remove the logic from wl.c. Amend comments there as well.
3. Grep everything in UBI and UBIFS for patterns like
"term/short/unknown" and amend the commentaries. There should be handful
of them, AFAIR.
Thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] UBI: Kill data type hint
Date: Sun, 13 May 2012 17:26:06 +0300 [thread overview]
Message-ID: <1336919166.2003.7.camel@koala> (raw)
In-Reply-To: <1336738443-112022-1-git-send-email-richard@nod.at>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Fri, 2012-05-11 at 14:14 +0200, Richard Weinberger wrote:
> Artem,
>
> Do you want this change as singe patch or shall I split it up?
> For now I made it as single patch to avoid build errors while
> bisecting.
Hi Richard,
I'd like to merge it to 3.5, so making it easier to review would be
great. Could you please do split it at least on 2 patches, may be even
thee:
1. Remove the function arguments dtype also in comments to these
functions. This should be the largest patch, but should be no-brainer.
2. Remove the logic from wl.c. Amend comments there as well.
3. Grep everything in UBI and UBIFS for patterns like
"term/short/unknown" and amend the commentaries. There should be handful
of them, AFAIR.
Thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-13 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 12:14 [RFC] UBI: Kill data type hint Richard Weinberger
2012-05-11 12:14 ` Richard Weinberger
2012-05-11 12:14 ` [PATCH] " Richard Weinberger
2012-05-11 12:14 ` Richard Weinberger
2012-05-13 14:41 ` Artem Bityutskiy
2012-05-13 14:41 ` Artem Bityutskiy
2012-05-13 15:28 ` Richard Weinberger
2012-05-13 15:28 ` Richard Weinberger
2012-05-13 14:26 ` Artem Bityutskiy [this message]
2012-05-13 14:26 ` Artem Bityutskiy
2012-05-13 14:37 ` Richard Weinberger
2012-05-13 14:37 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336919166.2003.7.camel@koala \
--to=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.