* [PATCH 2/2] lib/bb/siggen.py: ensure dumped signatures have group R/W
@ 2012-05-12 1:21 Joshua Lock
2012-05-13 19:02 ` Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Joshua Lock @ 2012-05-12 1:21 UTC (permalink / raw)
To: bitbake-devel
We anticipate signatures being shared amongst peers in a group so ensure
they have rw-rw-r-- permissions to facilitate this.
Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
lib/bb/siggen.py | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index ca26919..5a0b80e 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -201,8 +201,10 @@ class SignatureGeneratorBasic(SignatureGenerator):
for dep in data['runtaskdeps']:
data['runtaskhashes'][dep] = self.taskhash[dep]
- p = pickle.Pickler(open(sigfile, "wb"), -1)
- p.dump(data)
+ with open(sigfile, "wb") as f:
+ p = pickle.Pickler(f, -1)
+ p.dump(data)
+ os.chmod(sigfile, 0664)
def dump_sigs(self, dataCache):
for fn in self.taskdeps:
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] lib/bb/siggen.py: ensure dumped signatures have group R/W
2012-05-12 1:21 [PATCH 2/2] lib/bb/siggen.py: ensure dumped signatures have group R/W Joshua Lock
@ 2012-05-13 19:02 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2012-05-13 19:02 UTC (permalink / raw)
To: Joshua Lock; +Cc: bitbake-devel
On Fri, 2012-05-11 at 18:21 -0700, Joshua Lock wrote:
> We anticipate signatures being shared amongst peers in a group so ensure
> they have rw-rw-r-- permissions to facilitate this.
>
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
> lib/bb/siggen.py | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
Merged to master (along with 1/2) thanks.
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-13 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-12 1:21 [PATCH 2/2] lib/bb/siggen.py: ensure dumped signatures have group R/W Joshua Lock
2012-05-13 19:02 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.