* [PATCH RESEND] x86: kernel/dumpstack.c simple_strtoul cleanup
@ 2012-05-06 17:58 Shuah Khan
2012-05-14 15:02 ` Shuah Khan
2012-05-16 21:44 ` [tip:x86/cleanups] " tip-bot for Shuah Khan
0 siblings, 2 replies; 3+ messages in thread
From: Shuah Khan @ 2012-05-06 17:58 UTC (permalink / raw)
To: mingo, hpa, tglx; +Cc: shuahkhan, linux-kernel@vger.kernel.org
Change kstack_setup() and code_bytes_setup() in kernel/dumpstack.c
to call kstrtoul() instead of calling obsoleted simple_strtoul().
Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
---
arch/x86/kernel/dumpstack.c | 21 +++++++++++++++++++--
1 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 1b81839..b154f6d 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -311,16 +311,33 @@ void die(const char *str, struct pt_regs *regs, long err)
static int __init kstack_setup(char *s)
{
+ ssize_t ret;
+ unsigned long val;
+
if (!s)
return -EINVAL;
- kstack_depth_to_print = simple_strtoul(s, NULL, 0);
+
+ ret = kstrtoul(s, 0, &val);
+ if (ret)
+ return ret;
+ kstack_depth_to_print = val;
return 0;
}
early_param("kstack", kstack_setup);
static int __init code_bytes_setup(char *s)
{
- code_bytes = simple_strtoul(s, NULL, 0);
+ ssize_t ret;
+ unsigned long val;
+
+ if (!s)
+ return -EINVAL;
+
+ ret = kstrtoul(s, 0, &val);
+ if (ret)
+ return ret;
+
+ code_bytes = val;
if (code_bytes > 8192)
code_bytes = 8192;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] x86: kernel/dumpstack.c simple_strtoul cleanup
2012-05-06 17:58 [PATCH RESEND] x86: kernel/dumpstack.c simple_strtoul cleanup Shuah Khan
@ 2012-05-14 15:02 ` Shuah Khan
2012-05-16 21:44 ` [tip:x86/cleanups] " tip-bot for Shuah Khan
1 sibling, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2012-05-14 15:02 UTC (permalink / raw)
To: mingo; +Cc: shuahkhan, hpa, tglx, linux-kernel@vger.kernel.org
On Sun, 2012-05-06 at 11:58 -0600, Shuah Khan wrote:
> Change kstack_setup() and code_bytes_setup() in kernel/dumpstack.c
> to call kstrtoul() instead of calling obsoleted simple_strtoul().
>
How about this patch? Are you not interested in this type of cleanup
patches? Looking for some feedback so I can spend my energies on
something that would be worth while :)
-- Shuah
>
> Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
> ---
> arch/x86/kernel/dumpstack.c | 21 +++++++++++++++++++--
> 1 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
> index 1b81839..b154f6d 100644
> --- a/arch/x86/kernel/dumpstack.c
> +++ b/arch/x86/kernel/dumpstack.c
> @@ -311,16 +311,33 @@ void die(const char *str, struct pt_regs *regs, long err)
>
> static int __init kstack_setup(char *s)
> {
> + ssize_t ret;
> + unsigned long val;
> +
> if (!s)
> return -EINVAL;
> - kstack_depth_to_print = simple_strtoul(s, NULL, 0);
> +
> + ret = kstrtoul(s, 0, &val);
> + if (ret)
> + return ret;
> + kstack_depth_to_print = val;
> return 0;
> }
> early_param("kstack", kstack_setup);
>
> static int __init code_bytes_setup(char *s)
> {
> - code_bytes = simple_strtoul(s, NULL, 0);
> + ssize_t ret;
> + unsigned long val;
> +
> + if (!s)
> + return -EINVAL;
> +
> + ret = kstrtoul(s, 0, &val);
> + if (ret)
> + return ret;
> +
> + code_bytes = val;
> if (code_bytes > 8192)
> code_bytes = 8192;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:x86/cleanups] x86: kernel/dumpstack.c simple_strtoul cleanup
2012-05-06 17:58 [PATCH RESEND] x86: kernel/dumpstack.c simple_strtoul cleanup Shuah Khan
2012-05-14 15:02 ` Shuah Khan
@ 2012-05-16 21:44 ` tip-bot for Shuah Khan
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Shuah Khan @ 2012-05-16 21:44 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, shuahkhan, tglx, hpa
Commit-ID: 363f7ce3250aafdaab43011c7dc40158ea571e6b
Gitweb: http://git.kernel.org/tip/363f7ce3250aafdaab43011c7dc40158ea571e6b
Author: Shuah Khan <shuahkhan@gmail.com>
AuthorDate: Sun, 6 May 2012 11:58:04 -0600
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Tue, 15 May 2012 15:36:42 -0700
x86: kernel/dumpstack.c simple_strtoul cleanup
Change kstack_setup() and code_bytes_setup() in kernel/dumpstack.c
to call kstrtoul() instead of calling obsoleted simple_strtoul().
Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
Link: http://lkml.kernel.org/r/1336327084.2897.15.camel@lorien2
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/kernel/dumpstack.c | 21 +++++++++++++++++++--
1 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 1b81839..b154f6d 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -311,16 +311,33 @@ void die(const char *str, struct pt_regs *regs, long err)
static int __init kstack_setup(char *s)
{
+ ssize_t ret;
+ unsigned long val;
+
if (!s)
return -EINVAL;
- kstack_depth_to_print = simple_strtoul(s, NULL, 0);
+
+ ret = kstrtoul(s, 0, &val);
+ if (ret)
+ return ret;
+ kstack_depth_to_print = val;
return 0;
}
early_param("kstack", kstack_setup);
static int __init code_bytes_setup(char *s)
{
- code_bytes = simple_strtoul(s, NULL, 0);
+ ssize_t ret;
+ unsigned long val;
+
+ if (!s)
+ return -EINVAL;
+
+ ret = kstrtoul(s, 0, &val);
+ if (ret)
+ return ret;
+
+ code_bytes = val;
if (code_bytes > 8192)
code_bytes = 8192;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-16 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-06 17:58 [PATCH RESEND] x86: kernel/dumpstack.c simple_strtoul cleanup Shuah Khan
2012-05-14 15:02 ` Shuah Khan
2012-05-16 21:44 ` [tip:x86/cleanups] " tip-bot for Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.