From: Hannes Reinecke <hare@suse.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Hannes Reinecke <hare@suse.de>, Gleb Natapov <gleb@redhat.com>,
"H. Peter Anvin" <hpa@linux.intel.com>
Subject: [PATCH] EDD: Check for correct EDD 3.0 length
Date: Tue, 15 May 2012 13:04:49 +0200 [thread overview]
Message-ID: <1337079889-62380-1-git-send-email-hare@suse.de> (raw)
The device_path_info_length for EDD 3.0 is 36, not 44.
Cf http://mbldr.sourceforge.net/specsedd30.pdf.
This is a regression introduced by commit
0c61227094b3ddaca2f847ee287c4a2e3762b5a2
Signed-off-by: Hannes Reinecke <hare@suse.de>
Cc: Gleb Natapov <gleb@redhat.com>
Cc: H. Peter Anvin <hpa@linux.intel.com>
diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index e229576..09a77d5 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -545,8 +545,8 @@ edd_has_edd30(struct edd_device *edev)
}
- /* We support only T13 spec */
- if (info->params.device_path_info_length != 44)
+ /* EDD 3.0 specifies this to be 36 */
+ if (info->params.device_path_info_length != 36)
return 0;
for (i = 30; i < info->params.device_path_info_length + 30; i++)
next reply other threads:[~2012-05-15 11:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 11:04 Hannes Reinecke [this message]
2012-05-15 11:12 ` [PATCH] EDD: Check for correct EDD 3.0 length Gleb Natapov
2012-05-15 11:20 ` Hannes Reinecke
2012-05-15 11:59 ` Gleb Natapov
2012-05-15 12:53 ` Gleb Natapov
2012-05-15 13:49 ` Alan Cox
2012-05-15 14:12 ` Gleb Natapov
2012-05-15 14:18 ` Alan Cox
2012-05-15 14:21 ` Gleb Natapov
2012-05-15 14:36 ` Alan Cox
2012-05-15 14:48 ` Gleb Natapov
2012-05-15 14:54 ` Alan Cox
2012-05-15 15:00 ` Gleb Natapov
2012-05-15 14:00 ` Alan Cox
2012-05-15 14:36 ` Gleb Natapov
2012-05-15 14:52 ` Alan Cox
2012-05-15 14:53 ` Gleb Natapov
2012-05-15 15:22 ` Alan Cox
2012-05-15 15:29 ` Gleb Natapov
2012-05-15 15:41 ` Alan Cox
2012-05-15 15:53 ` Gleb Natapov
2012-05-15 15:14 ` Alan Cox
2012-05-15 15:31 ` Alan Cox
2012-05-15 15:46 ` Gleb Natapov
2012-05-15 17:17 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2012-05-16 6:51 Hannes Reinecke
2012-05-16 8:28 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337079889-62380-1-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=gleb@redhat.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.