Re: [PATCH] EDD: Check for correct EDD 3.0 length

[Gleb Natapov <gleb@redhat.com>]

Next time you resent an email say why you are doing it (wrong lkml
address in this case).

On Tue, May 15, 2012 at 01:04:49PM +0200, Hannes Reinecke wrote:
> The device_path_info_length for EDD 3.0 is 36, not 44.
> Cf http://mbldr.sourceforge.net/specsedd30.pdf.
> 
That's the wrong spec.

> This is a regression introduced by commit
> 0c61227094b3ddaca2f847ee287c4a2e3762b5a2
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Cc: Gleb Natapov <gleb@redhat.com>
> Cc: H. Peter Anvin <hpa@linux.intel.com>
> 
> diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
> index e229576..09a77d5 100644
> --- a/drivers/firmware/edd.c
> +++ b/drivers/firmware/edd.c
> @@ -545,8 +545,8 @@ edd_has_edd30(struct edd_device *edev)
>  	}
>  
>  
> -	/* We support only T13 spec */
> -	if (info->params.device_path_info_length != 44)
Here is the spec that code supports is spelled out, but you just replace
the comment with pointer to the spec that the code does not support.

> +	/* EDD 3.0 specifies this to be 36 */
> +	if (info->params.device_path_info_length != 36)
>  		return 0;
>  
>  	for (i = 30; i < info->params.device_path_info_length + 30; i++)

--
			Gleb.