From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-mtd@lists.infradead.org,
uClinux development list <uclinux-dev@uclinux.org>,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [uClinux-dev] [PATCH] mtd: clean up uclinux.c map driver
Date: Wed, 16 May 2012 12:28:52 +0300 [thread overview]
Message-ID: <1337160532.24809.28.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <CAMjpGUcteBCy7OLVgxF1sDTNi4XqCKsetEQSW-dpG0Ji4mUh2A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Tue, 2012-05-15 at 11:57 -0400, Mike Frysinger wrote:
> On Tue, May 15, 2012 at 12:08 AM, <gerg@snapgear.com> wrote:
> > . make the struct uclinux_ram_map static
>
> NAK: this breaks Blackfin systems. we specifically don't want this to
> be static.
>
> it should probably get a comment added above it saying as much.
I've just amended that patch and made it non-static as well. But this is
really ugly dependency.
diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
index ad75346..d8aa6df 100644
--- a/drivers/mtd/maps/uclinux.c
+++ b/drivers/mtd/maps/uclinux.c
@@ -21,7 +21,7 @@
extern char _ebss;
-static struct map_info uclinux_ram_map = {
+struct map_info uclinux_ram_map = {
.name = "RAM",
.phys = (unsigned long)&_ebss,
.size = 0,
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-16 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 4:08 [PATCH] mtd: clean up uclinux.c map driver gerg
2012-05-15 4:17 ` [uClinux-dev] " Greg Ungerer
2012-05-15 13:12 ` Artem Bityutskiy
2012-05-16 0:43 ` Greg Ungerer
2012-05-15 15:57 ` [uClinux-dev] " Mike Frysinger
2012-05-16 0:45 ` Greg Ungerer
2012-05-16 2:42 ` Mike Frysinger
2012-05-16 2:55 ` Greg Ungerer
2012-05-16 5:02 ` Mike Frysinger
2012-05-16 11:49 ` Greg Ungerer
2012-05-16 16:23 ` Mike Frysinger
2012-05-16 9:28 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337160532.24809.28.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=gerg@uclinux.org \
--cc=linux-mtd@lists.infradead.org \
--cc=uclinux-dev@uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.