From: Greg Ungerer <gerg@snapgear.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Greg Ungerer <gerg@uclinux.org>,
linux-mtd@lists.infradead.org,
uClinux development list <uclinux-dev@uclinux.org>,
dedekind1@gmail.com
Subject: Re: [uClinux-dev] [PATCH] mtd: clean up uclinux.c map driver
Date: Wed, 16 May 2012 10:45:29 +1000 [thread overview]
Message-ID: <4FB2F8A9.6010909@snapgear.com> (raw)
In-Reply-To: <CAMjpGUcteBCy7OLVgxF1sDTNi4XqCKsetEQSW-dpG0Ji4mUh2A@mail.gmail.com>
On 16/05/12 01:57, Mike Frysinger wrote:
> On Tue, May 15, 2012 at 12:08 AM,<gerg@snapgear.com> wrote:
>> . make the struct uclinux_ram_map static
>
> NAK: this breaks Blackfin systems. we specifically don't want this to
> be static.
>
> it should probably get a comment added above it saying as much.
A comment won't fix the sparse warning. You need a proper declaration.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-05-16 0:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 4:08 [PATCH] mtd: clean up uclinux.c map driver gerg
2012-05-15 4:17 ` [uClinux-dev] " Greg Ungerer
2012-05-15 13:12 ` Artem Bityutskiy
2012-05-16 0:43 ` Greg Ungerer
2012-05-15 15:57 ` [uClinux-dev] " Mike Frysinger
2012-05-16 0:45 ` Greg Ungerer [this message]
2012-05-16 2:42 ` Mike Frysinger
2012-05-16 2:55 ` Greg Ungerer
2012-05-16 5:02 ` Mike Frysinger
2012-05-16 11:49 ` Greg Ungerer
2012-05-16 16:23 ` Mike Frysinger
2012-05-16 9:28 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB2F8A9.6010909@snapgear.com \
--to=gerg@snapgear.com \
--cc=dedekind1@gmail.com \
--cc=gerg@uclinux.org \
--cc=linux-mtd@lists.infradead.org \
--cc=uclinux-dev@uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.