From: Artem Bityutskiy <dedekind1@gmail.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: hongxu.cn@gmail.com, nicolas.ferre@atmel.com,
linux-mtd@lists.infradead.org, ivan.djelic@parrot.com,
plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org,
"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: Re: [PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller
Date: Thu, 17 May 2012 14:43:31 +0300 [thread overview]
Message-ID: <1337255011.2564.2.camel@koala> (raw)
In-Reply-To: <4FB49C60.5030002@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On Thu, 2012-05-17 at 14:36 +0800, Josh Wu wrote:
> >> message text should not be split across lines anyway to ease grepping
> >> for the message.
> > I think the consensus is that it is personal decision of the author. I
> > am not trying to enforce this and I also split messages. In this case I
> > was only wondering why that backslash is used? I never saw this before
> > in the linux kernel.
> >
>
> oh, I add the backslash only because if without it, there should be a
> warning about message is splitting into two lines.
Backslash is not needed in C. The preprocessor removes it anyway. We do
not put them.
> Now I think I will just keep the text message in one line. That will
> avoid any warnings. thanks.
You can just remove the backslashes. I think your lines splitting is
fine otherwise.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller
Date: Thu, 17 May 2012 14:43:31 +0300 [thread overview]
Message-ID: <1337255011.2564.2.camel@koala> (raw)
In-Reply-To: <4FB49C60.5030002@atmel.com>
On Thu, 2012-05-17 at 14:36 +0800, Josh Wu wrote:
> >> message text should not be split across lines anyway to ease grepping
> >> for the message.
> > I think the consensus is that it is personal decision of the author. I
> > am not trying to enforce this and I also split messages. In this case I
> > was only wondering why that backslash is used? I never saw this before
> > in the linux kernel.
> >
>
> oh, I add the backslash only because if without it, there should be a
> warning about message is splitting into two lines.
Backslash is not needed in C. The preprocessor removes it anyway. We do
not put them.
> Now I think I will just keep the text message in one line. That will
> avoid any warnings. thanks.
You can just remove the backslashes. I think your lines splitting is
fine otherwise.
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120517/c59c579b/attachment.sig>
next prev parent reply other threads:[~2012-05-17 11:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 14:47 [PATCH v7 0/3] Add PMECC support for at91 nand flash driver Josh Wu
2012-05-15 14:47 ` Josh Wu
2012-05-15 14:47 ` [PATCH v7 1/3] MTD: at91: extract hw ecc initialization to one function Josh Wu
2012-05-15 14:47 ` Josh Wu
2012-05-15 14:47 ` [PATCH v7 2/3] MTD: add dt parameters for PMECC Josh Wu
2012-05-15 14:47 ` Josh Wu
2012-05-15 14:47 ` [PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller Josh Wu
2012-05-15 14:47 ` Josh Wu
2012-05-16 9:25 ` Artem Bityutskiy
2012-05-16 9:25 ` Artem Bityutskiy
2012-05-16 9:31 ` Lothar Waßmann
2012-05-16 9:31 ` Lothar Waßmann
2012-05-16 9:40 ` Artem Bityutskiy
2012-05-16 9:40 ` Artem Bityutskiy
2012-05-17 6:36 ` Josh Wu
2012-05-17 6:36 ` Josh Wu
2012-05-17 11:43 ` Artem Bityutskiy [this message]
2012-05-17 11:43 ` Artem Bityutskiy
2012-05-17 12:55 ` Russell King - ARM Linux
2012-05-17 12:55 ` Russell King - ARM Linux
2012-05-18 11:54 ` Artem Bityutskiy
2012-05-18 11:54 ` Artem Bityutskiy
2012-05-16 9:17 ` [PATCH v7 0/3] Add PMECC support for at91 nand flash driver Artem Bityutskiy
2012-05-16 9:17 ` Artem Bityutskiy
2012-05-17 6:32 ` Josh Wu
2012-05-17 6:32 ` Josh Wu
2012-05-17 11:42 ` Artem Bityutskiy
2012-05-17 11:42 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337255011.2564.2.camel@koala \
--to=dedekind1@gmail.com \
--cc=LW@KARO-electronics.de \
--cc=hongxu.cn@gmail.com \
--cc=ivan.djelic@parrot.com \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.