[PATCH 3/4] slub: use __SetPageSlab function to set PG_slab flag

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Joonsoo Kim <js1304@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Christoph Lameter <cl@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Joonsoo Kim <js1304@gmail.com>
Subject: [PATCH 3/4] slub: use __SetPageSlab function to set PG_slab flag
Date: Fri, 18 May 2012 00:47:47 +0900	[thread overview]
Message-ID: <1337269668-4619-4-git-send-email-js1304@gmail.com> (raw)
In-Reply-To: <1337269668-4619-1-git-send-email-js1304@gmail.com>

To set page-flag, using SetPageXXXX() and __SetPageXXXX() is more
understandable and maintainable. So change it.

Signed-off-by: Joonsoo Kim <js1304@gmail.com>

diff --git a/mm/slub.c b/mm/slub.c
index c38efce..69342fd 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1369,7 +1369,7 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
 
 	inc_slabs_node(s, page_to_nid(page), page->objects);
 	page->slab = s;
-	page->flags |= 1 << PG_slab;
+	__SetPageSlab(page);
 
 	start = page_address(page);
 
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: Joonsoo Kim <js1304@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Christoph Lameter <cl@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Joonsoo Kim <js1304@gmail.com>
Subject: [PATCH 3/4] slub: use __SetPageSlab function to set PG_slab flag
Date: Fri, 18 May 2012 00:47:47 +0900	[thread overview]
Message-ID: <1337269668-4619-4-git-send-email-js1304@gmail.com> (raw)
In-Reply-To: <1337269668-4619-1-git-send-email-js1304@gmail.com>

To set page-flag, using SetPageXXXX() and __SetPageXXXX() is more
understandable and maintainable. So change it.

Signed-off-by: Joonsoo Kim <js1304@gmail.com>

diff --git a/mm/slub.c b/mm/slub.c
index c38efce..69342fd 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1369,7 +1369,7 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
 
 	inc_slabs_node(s, page_to_nid(page), page->objects);
 	page->slab = s;
-	page->flags |= 1 << PG_slab;
+	__SetPageSlab(page);
 
 	start = page_address(page);
 
-- 
1.7.9.5

next prev parent reply	other threads:[~2012-05-17 15:50 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 15:47 [PATCH 0/4] slub: refactoring some code in slub Joonsoo Kim
2012-05-17 15:47 ` Joonsoo Kim
2012-05-17 15:47 ` [PATCH 1/4] slub: change cmpxchg_double_slab in get_freelist() to __cmpxchg_double_slab Joonsoo Kim
2012-05-17 15:47   ` Joonsoo Kim
2012-05-17 15:47 ` [PATCH 2/4] slub: change cmpxchg_double_slab in unfreeze_partials " Joonsoo Kim
2012-05-17 15:47   ` Joonsoo Kim
2012-05-17 15:47 ` Joonsoo Kim [this message]
2012-05-17 15:47   ` [PATCH 3/4] slub: use __SetPageSlab function to set PG_slab flag Joonsoo Kim
2012-05-17 16:07   ` Christoph Lameter
2012-05-17 16:07     ` Christoph Lameter
2012-05-18  9:31   ` Pekka Enberg
2012-05-18  9:31     ` Pekka Enberg
2012-05-17 15:47 ` [PATCH 4/4] slub: refactoring unfreeze_partials() Joonsoo Kim
2012-05-17 15:47   ` Joonsoo Kim
2012-05-17 18:30   ` Christoph Lameter
2012-05-17 18:30     ` Christoph Lameter
2012-05-18 13:11     ` JoonSoo Kim
2012-05-18 13:11       ` JoonSoo Kim
2012-06-01 12:28     ` Joonsoo Kim
2012-06-01 12:28       ` Joonsoo Kim
2012-06-01 15:57   ` Christoph Lameter
2012-06-01 15:57     ` Christoph Lameter
2012-05-17 16:08 ` [PATCH 0/4] slub: refactoring some code in slub Christoph Lameter
2012-05-17 16:08   ` Christoph Lameter
2012-05-17 16:34   ` JoonSoo Kim
2012-05-17 16:34     ` JoonSoo Kim
2012-05-17 16:41 ` [PATCH 1,2/4 v2] slub: use __cmpxchg_double_slab() at interrupt disabled place Joonsoo Kim
2012-05-17 16:41   ` Joonsoo Kim
2012-05-17 16:49   ` Christoph Lameter
2012-05-17 16:49     ` Christoph Lameter
2012-05-17 17:03     ` [PATCH 1,2/4 v3] " Joonsoo Kim
2012-05-17 17:03       ` Joonsoo Kim
2012-05-18  9:31     ` [PATCH 1,2/4 v2] " Pekka Enberg
2012-05-18  9:31       ` Pekka Enberg
2012-05-18 13:01       ` [PATCH 1,2/4 v4] " Joonsoo Kim
2012-05-18 13:01         ` Joonsoo Kim
2012-06-20  7:14         ` Pekka Enberg
2012-06-20  7:14           ` Pekka Enberg

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:c38efce dfblob:69342fd dfblob:c38efce dfblob:69342fd )
 OR (
bs:"[PATCH 3/4] slub: use __SetPageSlab function to set PG_slab flag" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337269668-4619-4-git-send-email-js1304@gmail.com \
    --to=js1304@gmail.com \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.