All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@gmail.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: [PATCH] multipath: fix select_no_path_retry for flushing devices.
Date: Sun, 20 May 2012 12:33:34 +0200	[thread overview]
Message-ID: <1337510014.27070.4.camel@lapoo.opensvc.com> (raw)
In-Reply-To: <20120518223326.GI3343@ether.msp.redhat.com>

On ven., 2012-05-18 at 17:33 -0500, Benjamin Marzinski wrote:
> The select_no_path_retry code was falling through if a flush was
> in progress, and so it wasn't honoring flush_on_last_del.
> 
Applied.

> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  libmultipath/propsel.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: multipath-tools-120403/libmultipath/propsel.c
> ===================================================================
> --- multipath-tools-120403.orig/libmultipath/propsel.c
> +++ multipath-tools-120403/libmultipath/propsel.c
> @@ -415,6 +415,7 @@ select_no_path_retry(struct multipath *m
>  	if (mp->flush_on_last_del == FLUSH_IN_PROGRESS) {
>  		condlog(0, "flush_on_last_del in progress");
>  		mp->no_path_retry = NO_PATH_RETRY_FAIL;
> +		return 0;
>  	}
>  	if (mp->mpe && mp->mpe->no_path_retry != NO_PATH_RETRY_UNDEF) {
>  		mp->no_path_retry = mp->mpe->no_path_retry;

      reply	other threads:[~2012-05-20 10:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 22:33 [PATCH] multipath: fix select_no_path_retry for flushing devices Benjamin Marzinski
2012-05-20 10:33 ` Christophe Varoqui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337510014.27070.4.camel@lapoo.opensvc.com \
    --to=christophe.varoqui@gmail.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.