* [PATCH] multipath: fix select_no_path_retry for flushing devices.
@ 2012-05-18 22:33 Benjamin Marzinski
2012-05-20 10:33 ` Christophe Varoqui
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Marzinski @ 2012-05-18 22:33 UTC (permalink / raw)
To: device-mapper development; +Cc: Christophe Varoqui
The select_no_path_retry code was falling through if a flush was
in progress, and so it wasn't honoring flush_on_last_del.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/propsel.c | 1 +
1 file changed, 1 insertion(+)
Index: multipath-tools-120403/libmultipath/propsel.c
===================================================================
--- multipath-tools-120403.orig/libmultipath/propsel.c
+++ multipath-tools-120403/libmultipath/propsel.c
@@ -415,6 +415,7 @@ select_no_path_retry(struct multipath *m
if (mp->flush_on_last_del == FLUSH_IN_PROGRESS) {
condlog(0, "flush_on_last_del in progress");
mp->no_path_retry = NO_PATH_RETRY_FAIL;
+ return 0;
}
if (mp->mpe && mp->mpe->no_path_retry != NO_PATH_RETRY_UNDEF) {
mp->no_path_retry = mp->mpe->no_path_retry;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] multipath: fix select_no_path_retry for flushing devices.
2012-05-18 22:33 [PATCH] multipath: fix select_no_path_retry for flushing devices Benjamin Marzinski
@ 2012-05-20 10:33 ` Christophe Varoqui
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Varoqui @ 2012-05-20 10:33 UTC (permalink / raw)
To: Benjamin Marzinski; +Cc: device-mapper development, Christophe Varoqui
On ven., 2012-05-18 at 17:33 -0500, Benjamin Marzinski wrote:
> The select_no_path_retry code was falling through if a flush was
> in progress, and so it wasn't honoring flush_on_last_del.
>
Applied.
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> libmultipath/propsel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: multipath-tools-120403/libmultipath/propsel.c
> ===================================================================
> --- multipath-tools-120403.orig/libmultipath/propsel.c
> +++ multipath-tools-120403/libmultipath/propsel.c
> @@ -415,6 +415,7 @@ select_no_path_retry(struct multipath *m
> if (mp->flush_on_last_del == FLUSH_IN_PROGRESS) {
> condlog(0, "flush_on_last_del in progress");
> mp->no_path_retry = NO_PATH_RETRY_FAIL;
> + return 0;
> }
> if (mp->mpe && mp->mpe->no_path_retry != NO_PATH_RETRY_UNDEF) {
> mp->no_path_retry = mp->mpe->no_path_retry;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-20 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-18 22:33 [PATCH] multipath: fix select_no_path_retry for flushing devices Benjamin Marzinski
2012-05-20 10:33 ` Christophe Varoqui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.