From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Cc: PowerPC email list <linuxppc-dev@lists.ozlabs.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Li Zhong <zhong@linux.vnet.ibm.com>
Subject: Re: [PATCH] cpuidle: (POWER) Replace pseries_notify_cpuidle_add call with a elegant notifier to fix lockdep problem in start_secondary
Date: Mon, 21 May 2012 10:49:38 +1000 [thread overview]
Message-ID: <1337561378.2458.3.camel@pasglop> (raw)
In-Reply-To: <1337561221.2458.1.camel@pasglop>
On Mon, 2012-05-21 at 10:47 +1000, Benjamin Herrenschmidt wrote:
> Any reason why you don't do cpuidle_disable_device() when the
> CPU is going offline and cpuidle_enable_device() when it's coming
> back ?
>
> I'm applying the patch for now since it fixes a real problem but
> if the above makes sense, please send a followup fix.
No I'm not ... it's damaged in some odd ways (some whitespace
missing here or there among others). Please resend a fixed one.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Cc: Li Zhong <zhong@linux.vnet.ibm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
PowerPC email list <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] cpuidle: (POWER) Replace pseries_notify_cpuidle_add call with a elegant notifier to fix lockdep problem in start_secondary
Date: Mon, 21 May 2012 10:49:38 +1000 [thread overview]
Message-ID: <1337561378.2458.3.camel@pasglop> (raw)
In-Reply-To: <1337561221.2458.1.camel@pasglop>
On Mon, 2012-05-21 at 10:47 +1000, Benjamin Herrenschmidt wrote:
> Any reason why you don't do cpuidle_disable_device() when the
> CPU is going offline and cpuidle_enable_device() when it's coming
> back ?
>
> I'm applying the patch for now since it fixes a real problem but
> if the above makes sense, please send a followup fix.
No I'm not ... it's damaged in some odd ways (some whitespace
missing here or there among others). Please resend a fixed one.
Cheers,
Ben.
next prev parent reply other threads:[~2012-05-21 0:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 13:28 [PATCH] cpuidle: (POWER) Replace pseries_notify_cpuidle_add call with a elegant notifier to fix lockdep problem in start_secondary Deepthi Dharwar
2012-05-21 0:47 ` Benjamin Herrenschmidt
2012-05-21 0:47 ` Benjamin Herrenschmidt
2012-05-21 0:49 ` Benjamin Herrenschmidt [this message]
2012-05-21 0:49 ` Benjamin Herrenschmidt
2012-05-21 4:34 ` [PATCH RESEND] " Deepthi Dharwar
2012-05-21 4:34 ` Deepthi Dharwar
2012-05-21 4:55 ` [PATCH] " Deepthi Dharwar
2012-05-21 4:55 ` Deepthi Dharwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337561378.2458.3.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=deepthi@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.