All of lore.kernel.org
 help / color / mirror / Atom feed
From: zwu.kernel@gmail.com
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
	stefanha@linux.vnet.ibm.com, linuxram@us.ibm.com,
	wuzhy@linux.vnet.ibm.com
Subject: [PATCH v2 07/15] net: Remove vlan code from net.c
Date: Wed, 23 May 2012 23:13:57 +0800	[thread overview]
Message-ID: <1337786045-2277-8-git-send-email-zwu.kernel@gmail.com> (raw)
In-Reply-To: <1337786045-2277-1-git-send-email-zwu.kernel@gmail.com>

From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

The vlan implementation in net.c has been replaced by hubs so we can
remove the code.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
 hw/xen_nic.c |    1 -
 net.c        |  108 ----------------------------------------------------------
 net.h        |    1 -
 3 files changed, 0 insertions(+), 110 deletions(-)

diff --git a/hw/xen_nic.c b/hw/xen_nic.c
index 9a59bda..85526fe 100644
--- a/hw/xen_nic.c
+++ b/hw/xen_nic.c
@@ -328,7 +328,6 @@ static int net_init(struct XenDevice *xendev)
         return -1;
     }
 
-    netdev->conf.vlan = qemu_find_vlan(netdev->xendev.dev, 1);
     netdev->conf.peer = NULL;
 
     netdev->nic = qemu_new_nic(&net_xen_info, &netdev->conf,
diff --git a/net.c b/net.c
index 96252f9..abf5a3d 100644
--- a/net.c
+++ b/net.c
@@ -388,50 +388,6 @@ static ssize_t qemu_deliver_packet(VLANClientState *sender,
     return ret;
 }
 
-static ssize_t qemu_vlan_deliver_packet(VLANClientState *sender,
-                                        unsigned flags,
-                                        const uint8_t *buf,
-                                        size_t size,
-                                        void *opaque)
-{
-    VLANState *vlan = opaque;
-    VLANClientState *vc;
-    ssize_t ret = -1;
-
-    QTAILQ_FOREACH(vc, &vlan->clients, next) {
-        ssize_t len;
-
-        if (vc == sender) {
-            continue;
-        }
-
-        if (vc->link_down) {
-            ret = size;
-            continue;
-        }
-
-        if (vc->receive_disabled) {
-            ret = 0;
-            continue;
-        }
-
-        if (flags & QEMU_NET_PACKET_FLAG_RAW && vc->info->receive_raw) {
-            len = vc->info->receive_raw(vc, buf, size);
-        } else {
-            len = vc->info->receive(vc, buf, size);
-        }
-
-        if (len == 0) {
-            vc->receive_disabled = 1;
-        }
-
-        ret = (ret >= 0) ? ret : len;
-
-    }
-
-    return ret;
-}
-
 void qemu_purge_queued_packets(VLANClientState *vc)
 {
     NetQueue *queue;
@@ -538,42 +494,6 @@ static ssize_t qemu_deliver_packet_iov(VLANClientState *sender,
     }
 }
 
-static ssize_t qemu_vlan_deliver_packet_iov(VLANClientState *sender,
-                                            unsigned flags,
-                                            const struct iovec *iov,
-                                            int iovcnt,
-                                            void *opaque)
-{
-    VLANState *vlan = opaque;
-    VLANClientState *vc;
-    ssize_t ret = -1;
-
-    QTAILQ_FOREACH(vc, &vlan->clients, next) {
-        ssize_t len;
-
-        if (vc == sender) {
-            continue;
-        }
-
-        if (vc->link_down) {
-            ret = iov_size(iov, iovcnt);
-            continue;
-        }
-
-        assert(!(flags & QEMU_NET_PACKET_FLAG_RAW));
-
-        if (vc->info->receive_iov) {
-            len = vc->info->receive_iov(vc, iov, iovcnt);
-        } else {
-            len = vc_sendv_compat(vc, iov, iovcnt);
-        }
-
-        ret = (ret >= 0) ? ret : len;
-    }
-
-    return ret;
-}
-
 ssize_t qemu_sendv_packet_async(VLANClientState *sender,
                                 const struct iovec *iov, int iovcnt,
                                 NetPacketSent *sent_cb)
@@ -601,34 +521,6 @@ qemu_sendv_packet(VLANClientState *vc, const struct iovec *iov, int iovcnt)
     return qemu_sendv_packet_async(vc, iov, iovcnt, NULL);
 }
 
-/* find or alloc a new VLAN */
-VLANState *qemu_find_vlan(int id, int allocate)
-{
-    VLANState *vlan;
-
-    QTAILQ_FOREACH(vlan, &vlans, next) {
-        if (vlan->id == id) {
-            return vlan;
-        }
-    }
-
-    if (!allocate) {
-        return NULL;
-    }
-
-    vlan = g_malloc0(sizeof(VLANState));
-    vlan->id = id;
-    QTAILQ_INIT(&vlan->clients);
-
-    vlan->send_queue = qemu_new_net_queue(qemu_vlan_deliver_packet,
-                                          qemu_vlan_deliver_packet_iov,
-                                          vlan);
-
-    QTAILQ_INSERT_TAIL(&vlans, vlan, next);
-
-    return vlan;
-}
-
 VLANClientState *qemu_find_netdev(const char *id)
 {
     VLANClientState *vc;
diff --git a/net.h b/net.h
index 7d18b10..a4ac48d 100644
--- a/net.h
+++ b/net.h
@@ -87,7 +87,6 @@ struct VLANState {
     NetQueue *send_queue;
 };
 
-VLANState *qemu_find_vlan(int id, int allocate);
 VLANClientState *qemu_find_netdev(const char *id);
 VLANClientState *qemu_new_net_client(NetClientInfo *info,
                                      VLANClientState *peer,
-- 
1.7.6


WARNING: multiple messages have this Message-ID (diff)
From: zwu.kernel@gmail.com
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, wuzhy@linux.vnet.ibm.com,
	linuxram@us.ibm.com, stefanha@linux.vnet.ibm.com,
	kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH v2 07/15] net: Remove vlan code from net.c
Date: Wed, 23 May 2012 23:13:57 +0800	[thread overview]
Message-ID: <1337786045-2277-8-git-send-email-zwu.kernel@gmail.com> (raw)
In-Reply-To: <1337786045-2277-1-git-send-email-zwu.kernel@gmail.com>

From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

The vlan implementation in net.c has been replaced by hubs so we can
remove the code.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
 hw/xen_nic.c |    1 -
 net.c        |  108 ----------------------------------------------------------
 net.h        |    1 -
 3 files changed, 0 insertions(+), 110 deletions(-)

diff --git a/hw/xen_nic.c b/hw/xen_nic.c
index 9a59bda..85526fe 100644
--- a/hw/xen_nic.c
+++ b/hw/xen_nic.c
@@ -328,7 +328,6 @@ static int net_init(struct XenDevice *xendev)
         return -1;
     }
 
-    netdev->conf.vlan = qemu_find_vlan(netdev->xendev.dev, 1);
     netdev->conf.peer = NULL;
 
     netdev->nic = qemu_new_nic(&net_xen_info, &netdev->conf,
diff --git a/net.c b/net.c
index 96252f9..abf5a3d 100644
--- a/net.c
+++ b/net.c
@@ -388,50 +388,6 @@ static ssize_t qemu_deliver_packet(VLANClientState *sender,
     return ret;
 }
 
-static ssize_t qemu_vlan_deliver_packet(VLANClientState *sender,
-                                        unsigned flags,
-                                        const uint8_t *buf,
-                                        size_t size,
-                                        void *opaque)
-{
-    VLANState *vlan = opaque;
-    VLANClientState *vc;
-    ssize_t ret = -1;
-
-    QTAILQ_FOREACH(vc, &vlan->clients, next) {
-        ssize_t len;
-
-        if (vc == sender) {
-            continue;
-        }
-
-        if (vc->link_down) {
-            ret = size;
-            continue;
-        }
-
-        if (vc->receive_disabled) {
-            ret = 0;
-            continue;
-        }
-
-        if (flags & QEMU_NET_PACKET_FLAG_RAW && vc->info->receive_raw) {
-            len = vc->info->receive_raw(vc, buf, size);
-        } else {
-            len = vc->info->receive(vc, buf, size);
-        }
-
-        if (len == 0) {
-            vc->receive_disabled = 1;
-        }
-
-        ret = (ret >= 0) ? ret : len;
-
-    }
-
-    return ret;
-}
-
 void qemu_purge_queued_packets(VLANClientState *vc)
 {
     NetQueue *queue;
@@ -538,42 +494,6 @@ static ssize_t qemu_deliver_packet_iov(VLANClientState *sender,
     }
 }
 
-static ssize_t qemu_vlan_deliver_packet_iov(VLANClientState *sender,
-                                            unsigned flags,
-                                            const struct iovec *iov,
-                                            int iovcnt,
-                                            void *opaque)
-{
-    VLANState *vlan = opaque;
-    VLANClientState *vc;
-    ssize_t ret = -1;
-
-    QTAILQ_FOREACH(vc, &vlan->clients, next) {
-        ssize_t len;
-
-        if (vc == sender) {
-            continue;
-        }
-
-        if (vc->link_down) {
-            ret = iov_size(iov, iovcnt);
-            continue;
-        }
-
-        assert(!(flags & QEMU_NET_PACKET_FLAG_RAW));
-
-        if (vc->info->receive_iov) {
-            len = vc->info->receive_iov(vc, iov, iovcnt);
-        } else {
-            len = vc_sendv_compat(vc, iov, iovcnt);
-        }
-
-        ret = (ret >= 0) ? ret : len;
-    }
-
-    return ret;
-}
-
 ssize_t qemu_sendv_packet_async(VLANClientState *sender,
                                 const struct iovec *iov, int iovcnt,
                                 NetPacketSent *sent_cb)
@@ -601,34 +521,6 @@ qemu_sendv_packet(VLANClientState *vc, const struct iovec *iov, int iovcnt)
     return qemu_sendv_packet_async(vc, iov, iovcnt, NULL);
 }
 
-/* find or alloc a new VLAN */
-VLANState *qemu_find_vlan(int id, int allocate)
-{
-    VLANState *vlan;
-
-    QTAILQ_FOREACH(vlan, &vlans, next) {
-        if (vlan->id == id) {
-            return vlan;
-        }
-    }
-
-    if (!allocate) {
-        return NULL;
-    }
-
-    vlan = g_malloc0(sizeof(VLANState));
-    vlan->id = id;
-    QTAILQ_INIT(&vlan->clients);
-
-    vlan->send_queue = qemu_new_net_queue(qemu_vlan_deliver_packet,
-                                          qemu_vlan_deliver_packet_iov,
-                                          vlan);
-
-    QTAILQ_INSERT_TAIL(&vlans, vlan, next);
-
-    return vlan;
-}
-
 VLANClientState *qemu_find_netdev(const char *id)
 {
     VLANClientState *vc;
diff --git a/net.h b/net.h
index 7d18b10..a4ac48d 100644
--- a/net.h
+++ b/net.h
@@ -87,7 +87,6 @@ struct VLANState {
     NetQueue *send_queue;
 };
 
-VLANState *qemu_find_vlan(int id, int allocate);
 VLANClientState *qemu_find_netdev(const char *id);
 VLANClientState *qemu_new_net_client(NetClientInfo *info,
                                      VLANClientState *peer,
-- 
1.7.6

  parent reply	other threads:[~2012-05-23 15:19 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 15:13 [PATCH v2 00/15] net: hub-based networking zwu.kernel
2012-05-23 15:13 ` [Qemu-devel] " zwu.kernel
2012-05-23 15:13 ` [PATCH v2 01/15] net: Add a hub net client zwu.kernel
2012-05-23 15:13   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:13 ` [PATCH v2 02/15] net: Use hubs for the vlan feature zwu.kernel
2012-05-23 15:13   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:13 ` [PATCH v2 03/15] net: Look up 'vlan' net clients using hubs zwu.kernel
2012-05-23 15:13   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:13 ` [PATCH v2 04/15] hub: Check that hubs are configured correctly zwu.kernel
2012-05-23 15:13   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:13 ` [PATCH v2 05/15] net: Drop vlan argument to qemu_new_net_client() zwu.kernel
2012-05-23 15:13   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:13 ` [PATCH v2 06/15] net: Remove vlan qdev property zwu.kernel
2012-05-23 15:13   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:13 ` zwu.kernel [this message]
2012-05-23 15:13   ` [Qemu-devel] [PATCH v2 07/15] net: Remove vlan code from net.c zwu.kernel
2012-05-23 15:13 ` [PATCH v2 08/15] net: Remove VLANState zwu.kernel
2012-05-23 15:13   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:13 ` [PATCH v2 09/15] net: Rename non_vlan_clients to net_clients zwu.kernel
2012-05-23 15:13   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:14 ` [PATCH v2 10/15] net: Rename VLANClientState to NetClientState zwu.kernel
2012-05-23 15:14   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:14 ` [PATCH v2 11/15] net: Rename vc local variables to nc zwu.kernel
2012-05-23 15:14   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:14 ` [PATCH v2 12/15] net: Rename qemu_del_vlan_client() to qemu_del_net_client() zwu.kernel
2012-05-23 15:14   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:14 ` [PATCH v2 13/15] net: Remove obsolete vlan info zwu.kernel
2012-05-23 15:14   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:41   ` Jan Kiszka
2012-05-23 15:41     ` [Qemu-devel] " Jan Kiszka
2012-05-24  2:42     ` Zhi Yong Wu
2012-05-24  2:42       ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 12:09       ` Jan Kiszka
2012-05-24 12:09         ` [Qemu-devel] " Jan Kiszka
2012-05-24 12:27         ` Zhi Yong Wu
2012-05-24 12:27           ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 13:30           ` Jan Kiszka
2012-05-24 13:30             ` [Qemu-devel] " Jan Kiszka
2012-05-24 14:12             ` Zhi Yong Wu
2012-05-24 14:12               ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 14:24               ` Jan Kiszka
2012-05-24 14:24                 ` [Qemu-devel] " Jan Kiszka
2012-05-24 12:34         ` Zhi Yong Wu
2012-05-24 12:34           ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 13:33           ` Jan Kiszka
2012-05-24 13:33             ` [Qemu-devel] " Jan Kiszka
2012-05-24 14:14             ` Zhi Yong Wu
2012-05-24 14:14               ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 14:25               ` Jan Kiszka
2012-05-24 14:25                 ` [Qemu-devel] " Jan Kiszka
2012-05-24 14:27                 ` Zhi Yong Wu
2012-05-24 14:27                   ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 14:31                   ` Jan Kiszka
2012-05-24 14:31                     ` [Qemu-devel] " Jan Kiszka
2012-05-24 14:38                     ` Zhi Yong Wu
2012-05-24 14:38                       ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 14:43                       ` Jan Kiszka
2012-05-24 14:43                         ` [Qemu-devel] " Jan Kiszka
2012-05-24 14:51                         ` Zhi Yong Wu
2012-05-24 14:51                           ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 15:01                           ` Jan Kiszka
2012-05-24 15:01                             ` [Qemu-devel] " Jan Kiszka
2012-05-24 14:59                         ` Zhi Yong Wu
2012-05-24 14:59                           ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 12:54         ` Zhi Yong Wu
2012-05-24 12:54           ` [Qemu-devel] " Zhi Yong Wu
2012-05-23 15:14 ` [PATCH v2 14/15] net: cleanup deliver/deliver_iov func pointers zwu.kernel
2012-05-23 15:14   ` [Qemu-devel] " zwu.kernel
2012-05-23 15:14 ` [PATCH v2 15/15] net: invoke qemu_can_send_packet only before net queue sending function zwu.kernel
2012-05-23 15:14   ` [Qemu-devel] " zwu.kernel
2012-05-23 16:00   ` Paolo Bonzini
2012-05-23 16:00     ` [Qemu-devel] " Paolo Bonzini
2012-05-24  4:05     ` Zhi Yong Wu
2012-05-24  4:05       ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 10:07       ` Paolo Bonzini
2012-05-24 10:07         ` [Qemu-devel] " Paolo Bonzini
2012-05-24 11:58         ` Zhi Yong Wu
2012-05-24 11:58           ` [Qemu-devel] " Zhi Yong Wu
2012-05-24 12:02           ` Paolo Bonzini
2012-05-24 12:02             ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337786045-2277-8-git-send-email-zwu.kernel@gmail.com \
    --to=zwu.kernel@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linuxram@us.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=wuzhy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.