* remove repeat implementation of page_referenced
@ 2012-05-25 12:37 Wanpeng Li
2012-05-25 12:47 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Wanpeng Li @ 2012-05-25 12:37 UTC (permalink / raw)
To: Andrew Morton, Hugh Dickins, David Rientjes, Peter Zijlstra
Cc: linux-kernel, Wanpeng Li, Wanpeng Li
From: Wanpeng Li <liwp@linux.vnet.ibm.com>
page_referenced function just called from mm/vmscan.c to handle paging
out.It is realized in mm/rmap.c and has an interface exported in rmap.h.
Signed-off-by: Wanpeng Li <liwp@linux.vnet.ibm.com>
---
include/linux/rmap.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/include/linux/rmap.h b/include/linux/rmap.h
index fd07c45..ee0c005 100644
--- a/include/linux/rmap.h
+++ b/include/linux/rmap.h
@@ -234,14 +234,6 @@ int rmap_walk(struct page *page, int (*rmap_one)(struct page *,
#define anon_vma_prepare(vma) (0)
#define anon_vma_link(vma) do {} while (0)
-static inline int page_referenced(struct page *page, int is_locked,
- struct mem_cgroup *memcg,
- unsigned long *vm_flags)
-{
- *vm_flags = 0;
- return 0;
-}
-
#define try_to_unmap(page, refs) SWAP_FAIL
static inline int page_mkclean(struct page *page)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: remove repeat implementation of page_referenced
2012-05-25 12:37 remove repeat implementation of page_referenced Wanpeng Li
@ 2012-05-25 12:47 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2012-05-25 12:47 UTC (permalink / raw)
To: Wanpeng Li
Cc: Andrew Morton, Hugh Dickins, David Rientjes, linux-kernel,
Wanpeng Li
On Fri, 2012-05-25 at 20:37 +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>
> page_referenced function just called from mm/vmscan.c to handle paging
> out.It is realized in mm/rmap.c and has an interface exported in rmap.h.
I think you'll find you've broken CONFIG_MMU=n builds with this.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-25 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-25 12:37 remove repeat implementation of page_referenced Wanpeng Li
2012-05-25 12:47 ` Peter Zijlstra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.