From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 00/14] More HDMI fixes V2
Date: Mon, 28 May 2012 16:42:47 -0300 [thread overview]
Message-ID: <1338234182-5021-1-git-send-email-przanoni@gmail.com> (raw)
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Following the comments I received and the discussions I had on IRC with Chris
and Daniel, here is the updated version. Even patch 0001 had changes, so I had
to do small adjustments on basically every single patch of the series so they
apply again.
Here is a list of changes:
0001: Add 'static' keywords (suggested by Chris)
0002: Small code change to be more defensive
0004: Add WARN to prevent future mistakes (suggested by Daniel)
0007: Small code change to be more defensive
New patches:
0012: drm/i915: clarify confusion between HDMI and SDVO registers
0013: drm/i915: add some barriers when changing DIPs
0014: drm/i915: make sure HDMI port is disabled inside set_infoframes
Patch 12 is my attempt to fix confusing names and prevent regressions like the
one that happened recently. Patch 13 was suggested by Chris and patch 14 was
suggested by Daniel.
So now the code seems pretty defensive :)
After this series is applied, I think we should go through bugzilla and start
suggesting people to test their HDMI bugs against the new tree.
Cheers,
Paulo
Paulo Zanoni (14):
drm/i915: add set_infoframes to struct intel_hdmi
drm/i915: properly alternate between DVI and HDMI
drm/i915: only set the HDMI port on the DIP once
drm/i915: enable DIP before enabling each InfoFrame
drm/i915: don't wait for vblank while writing InfoFrames
drm/i915: explicitly disable the DIPs we're not using
drm/i915: disable DIP while changing the port
drm/i915: don't write 0 to DIP control at HDMI init
drm/i915: don't set SDVO_BORDER_ENABLE when we're HDMI
drm/i915: rename sdvox_reg to hdmi_reg on HDMI context
drm/i915: remove comment about HSW HDMI DIPs
drm/i915: clarify confusion between HDMI and SDVO registers
drm/i915: add some barriers when changing DIPs
drm/i915: make sure HDMI port is disabled inside set_infoframes
drivers/gpu/drm/i915/i915_reg.h | 26 ++-
drivers/gpu/drm/i915/intel_ddi.c | 3 +-
drivers/gpu/drm/i915/intel_display.c | 38 ++--
drivers/gpu/drm/i915/intel_drv.h | 9 +-
drivers/gpu/drm/i915/intel_hdmi.c | 377 +++++++++++++++++++++++++---------
drivers/gpu/drm/i915/intel_sdvo.c | 18 +-
6 files changed, 334 insertions(+), 137 deletions(-)
--
1.7.10
next reply other threads:[~2012-05-28 19:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 19:42 Paulo Zanoni [this message]
2012-05-28 19:42 ` [PATCH 01/14] drm/i915: add set_infoframes to struct intel_hdmi Paulo Zanoni
2012-05-28 19:42 ` [PATCH 02/14] drm/i915: properly alternate between DVI and HDMI Paulo Zanoni
2012-05-28 19:53 ` Chris Wilson
2012-05-28 20:04 ` Paulo Zanoni
2012-05-28 19:42 ` [PATCH 03/14] drm/i915: only set the HDMI port on the DIP once Paulo Zanoni
2012-05-28 19:42 ` [PATCH 04/14] drm/i915: enable DIP before enabling each InfoFrame Paulo Zanoni
2012-05-28 19:42 ` [PATCH 05/14] drm/i915: don't wait for vblank while writing InfoFrames Paulo Zanoni
2012-05-28 19:42 ` [PATCH 06/14] drm/i915: explicitly disable the DIPs we're not using Paulo Zanoni
2012-05-28 19:42 ` [PATCH 07/14] drm/i915: disable DIP while changing the port Paulo Zanoni
2012-05-28 19:42 ` [PATCH 08/14] drm/i915: don't write 0 to DIP control at HDMI init Paulo Zanoni
2012-05-28 19:42 ` [PATCH 09/14] drm/i915: don't set SDVO_BORDER_ENABLE when we're HDMI Paulo Zanoni
2012-05-28 19:42 ` [PATCH 10/14] drm/i915: rename sdvox_reg to hdmi_reg on HDMI context Paulo Zanoni
2012-05-28 19:42 ` [PATCH 11/14] drm/i915: remove comment about HSW HDMI DIPs Paulo Zanoni
2012-05-28 19:42 ` [PATCH 12/14] drm/i915: clarify confusion between HDMI and SDVO registers Paulo Zanoni
2012-05-28 19:43 ` [PATCH 13/14] drm/i915: add some barriers when changing DIPs Paulo Zanoni
2012-05-30 21:08 ` Daniel Vetter
2012-05-28 19:43 ` [PATCH 14/14] drm/i915: make sure HDMI port is disabled inside set_infoframes Paulo Zanoni
2012-05-30 12:15 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338234182-5021-1-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.