Re: [PATCH 3/3] drm/i915: assert that the IBX port transcoder select w/a is implemented

[Chris Wilson <chris@chris-wilson.co.uk>]

On Wed, 30 May 2012 12:31:58 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Let's be a bit more paranoid here.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 3c71850..a9bc673 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1224,6 +1224,9 @@ static void assert_pch_dp_disabled(struct drm_i915_private *dev_priv,
>  	WARN(dp_pipe_enabled(dev_priv, pipe, port_sel, val),
>  	     "PCH DP (0x%08x) enabled on transcoder %c, should be disabled\n",
>  	     reg, pipe_name(pipe));
> +
> +	WARN(HAS_PCH_IBX(dev_priv->dev) && (val & SDVO_PIPE_B_SELECT),
> +	     "IBX PCH dp port still using transcoder B\n");

Only an issue if both pipe B selected and enabled, right?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre