From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/3] drm/i915: clarify IBX dp workaround
Date: Fri, 1 Jun 2012 21:40:18 +0200 [thread overview]
Message-ID: <20120601194018.GD5027@phenom.ffwll.local> (raw)
In-Reply-To: <1338373725_354455@CP5-2952>
On Wed, May 30, 2012 at 11:28:13AM +0100, Chris Wilson wrote:
> On Wed, 30 May 2012 12:31:56 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Instead of checking for !CPT, check for IBX to make it clearer that
> > this is a IBX-specific workaround. No functional change because we
> > smash the PPT PCH into the HAS_PCH_CPT check and atm DP isn't enabled
> > on the haswell LPT PCH yet.
> >
> > See Bspec Vol 3, Part 3, Section 4.[3-5].1 about DP[BCD], bit 30 for
> > details of this workaround.
> >
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the review. Can you also please look at the
other two patches again whether my replies are satisfactory?
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-06-01 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 10:31 [PATCH 1/3] drm/i915: clarify IBX dp workaround Daniel Vetter
2012-05-30 10:28 ` Chris Wilson
2012-06-01 19:40 ` Daniel Vetter [this message]
2012-06-01 20:04 ` Chris Wilson
2012-05-30 10:31 ` [PATCH 2/3] drm/i915: implement IBX hdmi transcoder select workaround Daniel Vetter
2012-05-30 10:39 ` Chris Wilson
2012-05-30 10:31 ` [PATCH 3/3] drm/i915: assert that the IBX port transcoder select w/a is implemented Daniel Vetter
2012-05-30 10:27 ` Chris Wilson
2012-05-30 11:30 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601194018.GD5027@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.