* [PATCH] regulator: max77686: Fix checkpatch warnings
@ 2012-06-04 1:59 Axel Lin
0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2012-06-04 1:59 UTC (permalink / raw)
To: linux-kernel
Cc: Chiwoong Byun, Jonghwa Lee, Myungjoo Ham, Kyungmin Park,
Yadwinder Singh Brar, Mark Brown, Liam Girdwood
Fix below checkpatch warnings:
$ scripts/checkpatch.pl -f drivers/regulator/max77686.c
ERROR: return is not a function, parentheses are not required
+ return (DIV_ROUND_UP(rdev->desc->uV_step
WARNING: line over 80 characters
+ .ops = &max77686_buck_dvs_ops, \
total: 1 errors, 1 warnings, 339 lines checked
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/max77686.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c
index 4e9f4f3..0815de1 100644
--- a/drivers/regulator/max77686.c
+++ b/drivers/regulator/max77686.c
@@ -75,9 +75,10 @@ static int max77686_set_dvs_voltage_time_sel(struct regulator_dev *rdev,
{
struct max77686_data *max77686 = rdev_get_drvdata(rdev);
int ramp_rate[] = {13, 27, 55, 100};
- return (DIV_ROUND_UP(rdev->desc->uV_step
- * abs(new_selector - old_selector),
- ramp_rate[max77686->ramp_delay]));
+
+ return DIV_ROUND_UP(rdev->desc->uV_step *
+ abs(new_selector - old_selector),
+ ramp_rate[max77686->ramp_delay]);
}
static int max77686_set_voltage_time_sel(struct regulator_dev *rdev,
@@ -171,7 +172,7 @@ static struct regulator_ops max77686_buck_dvs_ops = {
#define regulator_desc_buck_dvs(num) { \
.name = "BUCK"#num, \
.id = MAX77686_BUCK##num, \
- .ops = &max77686_buck_dvs_ops, \
+ .ops = &max77686_buck_dvs_ops, \
.type = REGULATOR_VOLTAGE, \
.owner = THIS_MODULE, \
.min_uV = MAX77686_DVS_MINUV, \
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-06-04 1:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-04 1:59 [PATCH] regulator: max77686: Fix checkpatch warnings Axel Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.