From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org, Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org, Alex Graf <agraf@suse.de>,
Alex Williamson <alex.williamson@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [RFC PATCH] PCI: Introduce INTx check & mask API
Date: Tue, 05 Jun 2012 11:39:42 +1000 [thread overview]
Message-ID: <1338860382.7150.97.camel@pasglop> (raw)
In-Reply-To: <4FBE2349.6040800@siemens.com>
On Thu, 2012-05-24 at 09:02 -0300, Jan Kiszka wrote:
>
> Since PCI 2.3, this bit is mandatory, and it should be independent of
> the masking bit. The question is, if your device is supposed to support
> 2.3, thus is just buggy,
It's a PCI Express device :-)
> or if our detection algorithm is unreliable. It
> basically builds on the assumption that, if we can flip the mask bit,
> the feature should be present. I guess that is the best we can do. Maybe
> we can augment this with a blacklist of devices that "support" flipping
> without actually providing the feature.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org, Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org, Alex Graf <agraf@suse.de>,
Alex Williamson <alex.williamson@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [RFC PATCH] PCI: Introduce INTx check & mask API
Date: Tue, 05 Jun 2012 11:39:42 +1000 [thread overview]
Message-ID: <1338860382.7150.97.camel@pasglop> (raw)
In-Reply-To: <4FBE2349.6040800@siemens.com>
On Thu, 2012-05-24 at 09:02 -0300, Jan Kiszka wrote:
>
> Since PCI 2.3, this bit is mandatory, and it should be independent of
> the masking bit. The question is, if your device is supposed to support
> 2.3, thus is just buggy,
It's a PCI Express device :-)
> or if our detection algorithm is unreliable. It
> basically builds on the assumption that, if we can flip the mask bit,
> the feature should be present. I guess that is the best we can do. Maybe
> we can augment this with a blacklist of devices that "support" flipping
> without actually providing the feature.
Cheers,
Ben.
next prev parent reply other threads:[~2012-06-05 1:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 7:44 [RFC PATCH] PCI: Introduce INTx check & mask API Alexey Kardashevskiy
2012-05-24 7:44 ` [Qemu-devel] " Alexey Kardashevskiy
2012-05-24 12:02 ` Jan Kiszka
2012-05-24 12:02 ` [Qemu-devel] " Jan Kiszka
2012-05-24 14:41 ` Alex Williamson
2012-05-24 14:41 ` [Qemu-devel] " Alex Williamson
2012-05-25 1:06 ` Alexey Kardashevskiy
2012-05-25 1:06 ` [Qemu-devel] " Alexey Kardashevskiy
2012-06-05 1:39 ` Benjamin Herrenschmidt
2012-06-05 1:39 ` [Qemu-devel] " Benjamin Herrenschmidt
2012-06-05 1:44 ` Alexander Graf
2012-06-05 1:44 ` [Qemu-devel] " Alexander Graf
2012-06-05 2:56 ` Benjamin Herrenschmidt
2012-06-05 2:56 ` [Qemu-devel] " Benjamin Herrenschmidt
2012-05-25 1:18 ` Alexey Kardashevskiy
2012-05-25 1:18 ` [Qemu-devel] " Alexey Kardashevskiy
2012-05-25 2:29 ` Jan Kiszka
2012-05-25 2:29 ` [Qemu-devel] " Jan Kiszka
2012-05-25 2:47 ` Alexey Kardashevskiy
2012-05-25 2:47 ` [Qemu-devel] " Alexey Kardashevskiy
2012-05-25 10:43 ` Jan Kiszka
2012-05-25 10:43 ` [Qemu-devel] " Jan Kiszka
2012-05-25 11:26 ` Alexey Kardashevskiy
2012-05-25 11:26 ` [Qemu-devel] " Alexey Kardashevskiy
2012-05-25 11:31 ` Jan Kiszka
2012-05-25 11:31 ` [Qemu-devel] " Jan Kiszka
2012-06-05 1:39 ` Benjamin Herrenschmidt [this message]
2012-06-05 1:39 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338860382.7150.97.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.