From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Stephane Eranian <eranian@google.com>
Cc: "Yan, Zheng" <zheng.z.yan@linux.intel.com>,
"Yan, Zheng" <zheng.z.yan@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Fix intel shared extra msr allocation
Date: Tue, 05 Jun 2012 12:27:51 +0200 [thread overview]
Message-ID: <1338892071.28282.157.camel@twins> (raw)
In-Reply-To: <CABPqkBSv8CbMzUiRsN2uOF1v6rFTpzhQqNbo7OKe-nzsus0GDg@mail.gmail.com>
On Tue, 2012-06-05 at 12:21 +0200, Stephane Eranian wrote:
> I agree with the first part of the patch in intel_try_alt_er(), we
> should not touch
> the actual event struct. But I am still unclear about the reg->alloc part.
reg->alloc is part of the actual event.
Thing is, the patch is horridly ugly.. while I agree that changing event
state isn't good, special casing all that code isn't good either.
I was looking at cloning the events for validate_group() as well, but so
far that's not turning out too pretty either.
next prev parent reply other threads:[~2012-06-05 10:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 3:20 [PATCH] perf: Fix intel shared extra msr allocation Yan, Zheng
2012-06-01 9:35 ` Stephane Eranian
2012-06-01 14:11 ` Yan, Zheng
2012-06-04 13:12 ` Stephane Eranian
2012-06-05 2:18 ` Yan, Zheng
2012-06-05 10:14 ` Peter Zijlstra
2012-06-05 10:21 ` Stephane Eranian
2012-06-05 10:27 ` Peter Zijlstra [this message]
2012-06-05 10:38 ` Stephane Eranian
2012-06-05 12:07 ` Peter Zijlstra
2012-06-05 12:39 ` Peter Zijlstra
2012-06-05 12:51 ` Stephane Eranian
2012-06-05 13:04 ` Peter Zijlstra
2012-06-05 13:30 ` [PATCH] perf, x86: Fix Intel shared extra MSR allocation Peter Zijlstra
2012-06-05 13:56 ` Peter Zijlstra
2012-06-05 21:26 ` Stephane Eranian
2012-06-06 1:00 ` Yan, Zheng
2012-06-06 15:57 ` [tip:perf/core] perf/x86: " tip-bot for Peter Zijlstra
2012-06-06 16:11 ` tip-bot for Peter Zijlstra
2012-06-05 13:31 ` [PATCH] perf: Fix intel shared extra msr allocation Stephane Eranian
2012-06-05 13:32 ` Peter Zijlstra
2012-06-05 13:38 ` Stephane Eranian
2012-06-05 13:47 ` Peter Zijlstra
2012-06-05 13:51 ` Stephane Eranian
2012-06-06 10:12 ` Stephane Eranian
2012-06-07 1:25 ` Yan, Zheng
2012-06-07 4:01 ` Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338892071.28282.157.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zheng.z.yan@intel.com \
--cc=zheng.z.yan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.