From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Mike Dunn <mikedunn@newsguy.com>
Subject: Re: flash bbt broken due to unitialized bitflip_threshold?
Date: Wed, 06 Jun 2012 16:30:53 +0300 [thread overview]
Message-ID: <1338989453.6875.49.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120606125013.5897a02d@pixies.home.jungo.com>
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
On Wed, 2012-06-06 at 12:50 +0300, Shmulik Ladkani wrote:
> + if (!mtd->bitflip_threshold)
> + mtd->bitflip_threshold = mtd->ecc_strength;
Hmm, why se default is to report bit-flips only when one more flipping
bit would cause an ECC error? The default be 1 - report on any bit-flip.
The same should be done in 'add_mtd_device()' - we should preserve the
old behavior, as it was before these patches. Do I miss something?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-06 13:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 22:06 flash bbt broken due to unitialized bitflip_threshold? Sascha Hauer
2012-06-06 9:50 ` Shmulik Ladkani
2012-06-06 13:30 ` Artem Bityutskiy [this message]
2012-06-06 15:15 ` Shmulik Ladkani
2012-06-06 15:46 ` Artem Bityutskiy
2012-06-06 16:08 ` Shmulik Ladkani
2012-06-06 17:55 ` Ivan Djelic
2012-06-07 7:36 ` Artem Bityutskiy
2012-06-07 14:02 ` Shmulik Ladkani
2012-06-07 17:34 ` Mike Dunn
2012-06-07 21:07 ` Shmulik Ladkani
2012-06-10 7:08 ` Shmulik Ladkani
2012-06-22 20:39 ` Brian Norris
2012-06-25 17:44 ` Mike Dunn
2012-06-07 7:43 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338989453.6875.49.camel@sauron.fi.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
--cc=s.hauer@pengutronix.de \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.