From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: Mike Dunn <mikedunn@newsguy.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-mtd@lists.infradead.org
Subject: Re: flash bbt broken due to unitialized bitflip_threshold?
Date: Wed, 06 Jun 2012 18:46:15 +0300 [thread overview]
Message-ID: <1338997575.6875.72.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120606181529.291aa9a6@halley>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
On Wed, 2012-06-06 at 18:15 +0300, Shmulik Ladkani wrote:
> - By 'add_mtd_device'. Here it defaults to 'ecc_strength' if NOT
> previously set by the driver.
But this is wrong. If I use the old doc2000 driver, with ecc_strength =
2, and it works fine for me, and I am happy that UBI scrubs for a single
bit-flip, why should my system become broken because someone decided
that now UBI should start scrubbing on 2 bit-flips?
We should not change the defaults - if I do not set the threshold via
sysfs of in the driver, it should be 1.
Unless I am completely confused, we should change this, CC -stable if
needed, and ask dwmw2 to merge that.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-06 15:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 22:06 flash bbt broken due to unitialized bitflip_threshold? Sascha Hauer
2012-06-06 9:50 ` Shmulik Ladkani
2012-06-06 13:30 ` Artem Bityutskiy
2012-06-06 15:15 ` Shmulik Ladkani
2012-06-06 15:46 ` Artem Bityutskiy [this message]
2012-06-06 16:08 ` Shmulik Ladkani
2012-06-06 17:55 ` Ivan Djelic
2012-06-07 7:36 ` Artem Bityutskiy
2012-06-07 14:02 ` Shmulik Ladkani
2012-06-07 17:34 ` Mike Dunn
2012-06-07 21:07 ` Shmulik Ladkani
2012-06-10 7:08 ` Shmulik Ladkani
2012-06-22 20:39 ` Brian Norris
2012-06-25 17:44 ` Mike Dunn
2012-06-07 7:43 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338997575.6875.72.camel@sauron.fi.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
--cc=s.hauer@pengutronix.de \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.