From: Dario Faggioli <raistlin@linux.it>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>,
Roger Pau Monne <roger.pau@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v6] libxl: introduce LIBXL_DOMAIN_TYPE_INVALID
Date: Wed, 06 Jun 2012 16:30:32 +0200 [thread overview]
Message-ID: <1338993032.8123.4.camel@Solace> (raw)
In-Reply-To: <1338991121.32319.105.camel@zakaz.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1159 bytes --]
On Wed, 2012-06-06 at 14:58 +0100, Ian Campbell wrote:
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
Cool! :-)
> > @@ -310,6 +311,7 @@ libxl_domain_build_info = Struct("domain
> > # Use host's E820 for PCI passthrough.
> > ("e820_host", libxl_defbool),
> > ])),
> > + ("invalid", Struct(None, [])),
> > ], keyvar_init_val = "-1")),
>
> This -1 should => LIBXL_DOMAIN_TYPE_INVALID,
>
Oh, you're right, I just wasn't sure I could put i here... And then I
forgot to try! :-P
> but I'll just make that
> change as I commit it, if that's ok with you...
>
It is, thanks.
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-06-06 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 13:42 [PATCH v6] libxl: introduce LIBXL_DOMAIN_TYPE_INVALID Dario Faggioli
2012-06-06 13:58 ` Ian Campbell
2012-06-06 14:30 ` Dario Faggioli [this message]
2012-06-06 14:38 ` Ian Campbell
2012-06-06 14:59 ` Ian Campbell
2012-06-07 7:18 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338993032.8123.4.camel@Solace \
--to=raistlin@linux.it \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.