Re: [PATCH v6] libxl: introduce LIBXL_DOMAIN_TYPE_INVALID

[Dario Faggioli <raistlin@linux.it>]

[-- Attachment #1.1: Type: text/plain, Size: 1230 bytes --]

On Wed, 2012-06-06 at 15:59 +0100, Ian Campbell wrote:
> On Wed, 2012-06-06 at 14:42 +0100, Dario Faggioli wrote:
> > To avoid recent gcc complaining about:
> > libxl.c: In function 'libxl_primary_console_exec':
> > libxl.c:1233:9: error: case value '4294967295' not in enumerated type 'libxl_domain_type' [-Werror=switch]
> > 
> > Also:
> >  - have all the call sites of libxl__domain_type() return with error in
> >    case the function returns LIBXL_DOMAIN_TYPE_INVALID;
> >  - adjust all other code segments where -Wswitch makes would claim that
> >    LIBXL_DOMAIN_TYPE_INVALID is not handled by adding a "default: abort();"
> >    clause.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> 
> Committed with the two changes I mentioned. Please check I haven't made
> a mess of things...
> 
I looked at it and it seems fine. Thanks for doing this,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel