From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Hiroo Matsumoto <matsumoto.hiroo@jp.fujitsu.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 0/2] Add pcibios_device_change_notifier
Date: Fri, 08 Jun 2012 07:31:51 +1000 [thread overview]
Message-ID: <1339104711.24838.29.camel@pasglop> (raw)
In-Reply-To: <4FD0A257.4070506@jp.fujitsu.com>
On Thu, 2012-06-07 at 21:45 +0900, Hiroo Matsumoto wrote:
>
> > Also you seem to add:
> >
> > + /* Setup OF node pointer in the device */
> > + dev->dev.of_node = pci_device_to_OF_node(dev);
> >
> > This shouldn't be needed anymore, the device node should be setup by the
> > core nowadays. Is this just a remnant of you rebasing an old patch or do
> > you have a good reason to add this statement ?
>
> No, I don't have a good reason to add this statement.
> I just tried to make this code be same with pcibios_setup_bus_devices.
> Thanks for your review and comment.
Unless I'm mistaken, this statement was removed from
pcibios_setup_bus_devices() recently so I'd say it's a leftover from
your patch having been originally done on top of an older kernel.
I won't be back for another week or so but I'll see if I can get things
tested in the meantime.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Hiroo Matsumoto <matsumoto.hiroo@jp.fujitsu.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
jbarnes@virtuousgeek.org,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Subject: Re: [PATCH v2 0/2] Add pcibios_device_change_notifier
Date: Fri, 08 Jun 2012 07:31:51 +1000 [thread overview]
Message-ID: <1339104711.24838.29.camel@pasglop> (raw)
In-Reply-To: <4FD0A257.4070506@jp.fujitsu.com>
On Thu, 2012-06-07 at 21:45 +0900, Hiroo Matsumoto wrote:
>
> > Also you seem to add:
> >
> > + /* Setup OF node pointer in the device */
> > + dev->dev.of_node = pci_device_to_OF_node(dev);
> >
> > This shouldn't be needed anymore, the device node should be setup by the
> > core nowadays. Is this just a remnant of you rebasing an old patch or do
> > you have a good reason to add this statement ?
>
> No, I don't have a good reason to add this statement.
> I just tried to make this code be same with pcibios_setup_bus_devices.
> Thanks for your review and comment.
Unless I'm mistaken, this statement was removed from
pcibios_setup_bus_devices() recently so I'd say it's a leftover from
your patch having been originally done on top of an older kernel.
I won't be back for another week or so but I'll see if I can get things
tested in the meantime.
Cheers,
Ben.
next prev parent reply other threads:[~2012-06-07 21:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 2:33 [PATCH v2 0/2] Add pcibios_device_change_notifier Hiroo Matsumoto
2012-05-23 2:33 ` Hiroo Matsumoto
2012-06-06 5:26 ` Benjamin Herrenschmidt
2012-06-06 5:26 ` Benjamin Herrenschmidt
2012-06-07 12:45 ` Hiroo Matsumoto
2012-06-07 12:45 ` Hiroo Matsumoto
2012-06-07 21:31 ` Benjamin Herrenschmidt [this message]
2012-06-07 21:31 ` Benjamin Herrenschmidt
2012-06-11 22:51 ` Bjorn Helgaas
2012-06-11 22:51 ` Bjorn Helgaas
2012-06-11 23:24 ` Benjamin Herrenschmidt
2012-06-11 23:24 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339104711.24838.29.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matsumoto.hiroo@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.