From: Sasha Levin <levinsasha928@gmail.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: dan.magenheimer@oracle.com, konrad.wilk@oracle.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/10] minor frontswap cleanups and tracing support
Date: Sat, 09 Jun 2012 00:38:03 +0200 [thread overview]
Message-ID: <1339195083.11360.1.camel@lappy> (raw)
In-Reply-To: <20120608220422.GA15294@localhost.localdomain>
On Fri, 2012-06-08 at 18:04 -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Jun 08, 2012 at 09:15:09PM +0200, Sasha Levin wrote:
> > Most of these patches are minor cleanups to the mm/frontswap.c code, the big
> > chunk of new code can be attributed to the new tracing support.
> >
> >
> > Changes in v2:
> > - Rebase to current version
> > - Address Konrad's comments
>
> There was one comment that I am not sure if it was emailed and that
> was about adding the "lockdep_assert_held(&swap_lock);".
>
> You added that in two patches, while the git commit only talks about
> "move that code" . Please remove it out of the "move the code" patches
> and add it as a seperate git commit with an explanation of why it
> is added.
argh, I forgot to comment on that as well. Sorry.
> Otherwise (well, the compile issue that was spotted) the patches
> look great. Could you repost them with those two fixes please?
Will do.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <levinsasha928@gmail.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: dan.magenheimer@oracle.com, konrad.wilk@oracle.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/10] minor frontswap cleanups and tracing support
Date: Sat, 09 Jun 2012 00:38:03 +0200 [thread overview]
Message-ID: <1339195083.11360.1.camel@lappy> (raw)
In-Reply-To: <20120608220422.GA15294@localhost.localdomain>
On Fri, 2012-06-08 at 18:04 -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Jun 08, 2012 at 09:15:09PM +0200, Sasha Levin wrote:
> > Most of these patches are minor cleanups to the mm/frontswap.c code, the big
> > chunk of new code can be attributed to the new tracing support.
> >
> >
> > Changes in v2:
> > - Rebase to current version
> > - Address Konrad's comments
>
> There was one comment that I am not sure if it was emailed and that
> was about adding the "lockdep_assert_held(&swap_lock);".
>
> You added that in two patches, while the git commit only talks about
> "move that code" . Please remove it out of the "move the code" patches
> and add it as a seperate git commit with an explanation of why it
> is added.
argh, I forgot to comment on that as well. Sorry.
> Otherwise (well, the compile issue that was spotted) the patches
> look great. Could you repost them with those two fixes please?
Will do.
next prev parent reply other threads:[~2012-06-08 22:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 19:15 [PATCH v2 00/10] minor frontswap cleanups and tracing support Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 01/10] mm: frontswap: remove casting from function calls through ops structure Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 02/10] mm: frontswap: trivial coding convention issues Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 20:16 ` Pekka Enberg
2012-06-08 20:16 ` Pekka Enberg
2012-06-08 20:36 ` Sasha Levin
2012-06-08 20:36 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 03/10] mm: frontswap: split out __frontswap_curr_pages Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 04/10] mm: frontswap: split out __frontswap_unuse_pages Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 05/10] mm: frontswap: split frontswap_shrink further to simplify locking Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 06/10] mm: frontswap: make all branches of if statement in put page consistent Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 07/10] mm: frontswap: remove unnecessary check during initialization Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 08/10] mm: frontswap: add tracing support Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 09/10] mm: frontswap: split out function to clear a page out Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 10/10] mm: frontswap: remove unneeded headers Sasha Levin
2012-06-08 19:15 ` Sasha Levin
2012-06-08 22:04 ` [PATCH v2 00/10] minor frontswap cleanups and tracing support Konrad Rzeszutek Wilk
2012-06-08 22:04 ` Konrad Rzeszutek Wilk
2012-06-08 22:38 ` Sasha Levin [this message]
2012-06-08 22:38 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339195083.11360.1.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=dan.magenheimer@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.