From: Wanpeng Li <liwp.linux@gmail.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: linux-kernel@vger.kernel.org,
Gavin Shan <shangw@linux.vnet.ibm.com>,
Wanpeng Li <liwp.linux@gmail.com>,
Wanpeng Li <liswp@linux.vnet.ibm.com>
Subject: [PATCH] writeback: avoid race when update bandwidth
Date: Tue, 12 Jun 2012 18:26:43 +0800 [thread overview]
Message-ID: <1339496803-2885-1-git-send-email-liwp.linux@gmail.com> (raw)
From: Wanpeng Li <liwp@linux.vnet.ibm.com>
Since bdi->wb.list_lock is used to protect the b_* lists,
so the flushers who call wb_writeback to writeback pages will
stuck when bandwidth update policy holds this lock. In order
to avoid this race we can introduce a new bandwidth_lock who
is responsible for protecting bandwidth update policy.
Signed-off-by: Wanpeng Li <liswp@linux.vnet.ibm.com>
---
mm/page-writeback.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index c8945e0..b3b08fb 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1032,12 +1032,14 @@ static void bdi_update_bandwidth(struct backing_dev_info *bdi,
unsigned long bdi_dirty,
unsigned long start_time)
{
+ static DEFINE_SPINLOCK(bandwidth_lock);
+
if (time_is_after_eq_jiffies(bdi->bw_time_stamp + BANDWIDTH_INTERVAL))
return;
- spin_lock(&bdi->wb.list_lock);
+ spin_lock(&bandwidth_lock);
__bdi_update_bandwidth(bdi, thresh, bg_thresh, dirty,
bdi_thresh, bdi_dirty, start_time);
- spin_unlock(&bdi->wb.list_lock);
+ spin_unlock(&bandwidth_lock);
}
/*
--
1.7.9.5
next reply other threads:[~2012-06-12 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 10:26 Wanpeng Li [this message]
2012-06-12 11:21 ` [PATCH] writeback: avoid race when update bandwidth Fengguang Wu
2012-06-12 11:29 ` Wanpeng Li
2012-06-12 11:33 ` Fengguang Wu
2012-06-13 3:56 ` Dave Chinner
2012-06-13 4:21 ` Fengguang Wu
2012-06-14 1:36 ` Dave Chinner
2012-06-14 13:48 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339496803-2885-1-git-send-email-liwp.linux@gmail.com \
--to=liwp.linux@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liswp@linux.vnet.ibm.com \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.