* [PATCH 0/1] kernel.py: replace os.popen with subprocess.Popen @ 2012-06-01 8:51 Robert Yang 2012-06-01 8:51 ` [PATCH 1/1] " Robert Yang 2012-06-11 17:50 ` [PATCH 0/1] " Flanagan, Elizabeth 0 siblings, 2 replies; 7+ messages in thread From: Robert Yang @ 2012-06-01 8:51 UTC (permalink / raw) To: poky Note: This is only for yocto, not for oe-core, since oe-core doesn't have scripts/lib/bsp/kernel.py. // Robert The following changes since commit de4cdfd6bc1280ac7ac0559b87734d26294ef773: documentation/kernel-manual/kernel-how-to.xml: Updated to kernel 3.4 (2012-05-31 21:16:55 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib robert/kernel_py http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/kernel_py Robert Yang (1): kernel.py: replace os.popen with subprocess.Popen scripts/lib/bsp/kernel.py | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] kernel.py: replace os.popen with subprocess.Popen 2012-06-01 8:51 [PATCH 0/1] kernel.py: replace os.popen with subprocess.Popen Robert Yang @ 2012-06-01 8:51 ` Robert Yang 2012-06-08 15:08 ` Darren Hart 2012-06-11 17:50 ` [PATCH 0/1] " Flanagan, Elizabeth 1 sibling, 1 reply; 7+ messages in thread From: Robert Yang @ 2012-06-01 8:51 UTC (permalink / raw) To: poky Replace os.popen with subprocess.Popen since the older function would fail (more or less) silently if the executed program cannot be found More info: http://docs.python.org/library/subprocess.html#subprocess-replacements [YOCTO #2454] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- scripts/lib/bsp/kernel.py | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/lib/bsp/kernel.py b/scripts/lib/bsp/kernel.py index 8b3aa72..7c6da4e 100644 --- a/scripts/lib/bsp/kernel.py +++ b/scripts/lib/bsp/kernel.py @@ -31,6 +31,7 @@ import os import shutil from tags import * import glob +import subprocess def find_bblayers(scripts_path): @@ -678,7 +679,7 @@ def base_branches(context): print "Getting branches from remote repo %s..." % giturl gitcmd = "git ls-remote %s *heads* 2>&1" % (giturl) - tmp = os.popen(gitcmd).read() + tmp = subprocess.Popen(gitcmd, shell=True, stdout=subprocess.PIPE).stdout.read() branches = [] @@ -708,7 +709,7 @@ def all_branches(context): print "Getting branches from remote repo %s..." % giturl gitcmd = "git ls-remote %s *heads* 2>&1" % (giturl) - tmp = os.popen(gitcmd).read() + tmp = subprocess.Popen(gitcmd, shell=True, stdout=subprocess.PIPE).stdout.read() branches = [] -- 1.7.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] kernel.py: replace os.popen with subprocess.Popen 2012-06-01 8:51 ` [PATCH 1/1] " Robert Yang @ 2012-06-08 15:08 ` Darren Hart 2012-06-08 15:14 ` Martin Jansa 0 siblings, 1 reply; 7+ messages in thread From: Darren Hart @ 2012-06-08 15:08 UTC (permalink / raw) To: Robert Yang; +Cc: poky On 06/01/2012 01:51 AM, Robert Yang wrote: > Replace os.popen with subprocess.Popen since the older function would > fail (more or less) silently if the executed program cannot be found > > More info: > http://docs.python.org/library/subprocess.html#subprocess-replacements > > [YOCTO #2454] > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > --- > scripts/lib/bsp/kernel.py | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/scripts/lib/bsp/kernel.py b/scripts/lib/bsp/kernel.py > index 8b3aa72..7c6da4e 100644 > --- a/scripts/lib/bsp/kernel.py > +++ b/scripts/lib/bsp/kernel.py > @@ -31,6 +31,7 @@ import os > import shutil > from tags import * > import glob > +import subprocess > > > def find_bblayers(scripts_path): > @@ -678,7 +679,7 @@ def base_branches(context): > print "Getting branches from remote repo %s..." % giturl > > gitcmd = "git ls-remote %s *heads* 2>&1" % (giturl) > - tmp = os.popen(gitcmd).read() > + tmp = subprocess.Popen(gitcmd, shell=True, stdout=subprocess.PIPE).stdout.read() Subprocess is right module to use here, but I believe the recommended method would be: subprocess.call(gitcmd... According to: http://docs.python.org/library/subprocess.html > > branches = [] > > @@ -708,7 +709,7 @@ def all_branches(context): > print "Getting branches from remote repo %s..." % giturl > > gitcmd = "git ls-remote %s *heads* 2>&1" % (giturl) > - tmp = os.popen(gitcmd).read() > + tmp = subprocess.Popen(gitcmd, shell=True, stdout=subprocess.PIPE).stdout.read() > > branches = [] > And here I think subprocess.check_output(...) is preferred. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] kernel.py: replace os.popen with subprocess.Popen 2012-06-08 15:08 ` Darren Hart @ 2012-06-08 15:14 ` Martin Jansa 2012-06-08 15:39 ` Darren Hart 0 siblings, 1 reply; 7+ messages in thread From: Martin Jansa @ 2012-06-08 15:14 UTC (permalink / raw) To: Darren Hart; +Cc: poky [-- Attachment #1: Type: text/plain, Size: 2210 bytes --] On Fri, Jun 08, 2012 at 08:08:59AM -0700, Darren Hart wrote: > > > On 06/01/2012 01:51 AM, Robert Yang wrote: > > Replace os.popen with subprocess.Popen since the older function would > > fail (more or less) silently if the executed program cannot be found > > > > More info: > > http://docs.python.org/library/subprocess.html#subprocess-replacements > > > > [YOCTO #2454] > > > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > > --- > > scripts/lib/bsp/kernel.py | 5 +++-- > > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/scripts/lib/bsp/kernel.py b/scripts/lib/bsp/kernel.py > > index 8b3aa72..7c6da4e 100644 > > --- a/scripts/lib/bsp/kernel.py > > +++ b/scripts/lib/bsp/kernel.py > > @@ -31,6 +31,7 @@ import os > > import shutil > > from tags import * > > import glob > > +import subprocess > > > > > > def find_bblayers(scripts_path): > > @@ -678,7 +679,7 @@ def base_branches(context): > > print "Getting branches from remote repo %s..." % giturl > > > > gitcmd = "git ls-remote %s *heads* 2>&1" % (giturl) > > - tmp = os.popen(gitcmd).read() > > + tmp = subprocess.Popen(gitcmd, shell=True, stdout=subprocess.PIPE).stdout.read() > > Subprocess is right module to use here, but I believe the recommended > method would be: > > subprocess.call(gitcmd... > > According to: > http://docs.python.org/library/subprocess.html > > > > > branches = [] > > > > @@ -708,7 +709,7 @@ def all_branches(context): > > print "Getting branches from remote repo %s..." % giturl > > > > gitcmd = "git ls-remote %s *heads* 2>&1" % (giturl) > > - tmp = os.popen(gitcmd).read() > > + tmp = subprocess.Popen(gitcmd, shell=True, stdout=subprocess.PIPE).stdout.read() > > > > branches = [] > > > > And here I think subprocess.check_output(...) is preferred. That's only in python 2.7 and newer, are distros with python-2.6 unsupported now? I did the same mistake in opkg-utils (patch for it is on yocto ML). https://lists.yoctoproject.org/pipermail/yocto/2012-May/009182.html Cheers, -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] kernel.py: replace os.popen with subprocess.Popen 2012-06-08 15:14 ` Martin Jansa @ 2012-06-08 15:39 ` Darren Hart 2012-06-12 10:34 ` Richard Purdie 0 siblings, 1 reply; 7+ messages in thread From: Darren Hart @ 2012-06-08 15:39 UTC (permalink / raw) To: Martin Jansa; +Cc: poky -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/08/2012 08:14 AM, Martin Jansa wrote: > On Fri, Jun 08, 2012 at 08:08:59AM -0700, Darren Hart wrote: >> >> >> On 06/01/2012 01:51 AM, Robert Yang wrote: >>> Replace os.popen with subprocess.Popen since the older function >>> would fail (more or less) silently if the executed program >>> cannot be found >>> >>> More info: >>> http://docs.python.org/library/subprocess.html#subprocess-replacements >>> >>> >>> [YOCTO #2454] >>> >>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- >>> scripts/lib/bsp/kernel.py | 5 +++-- 1 files changed, 3 >>> insertions(+), 2 deletions(-) >>> >>> diff --git a/scripts/lib/bsp/kernel.py >>> b/scripts/lib/bsp/kernel.py index 8b3aa72..7c6da4e 100644 --- >>> a/scripts/lib/bsp/kernel.py +++ b/scripts/lib/bsp/kernel.py @@ >>> -31,6 +31,7 @@ import os import shutil from tags import * >>> import glob +import subprocess >>> >>> >>> def find_bblayers(scripts_path): @@ -678,7 +679,7 @@ def >>> base_branches(context): print "Getting branches from remote >>> repo %s..." % giturl >>> >>> gitcmd = "git ls-remote %s *heads* 2>&1" % (giturl) - tmp = >>> os.popen(gitcmd).read() + tmp = subprocess.Popen(gitcmd, >>> shell=True, stdout=subprocess.PIPE).stdout.read() >> >> Subprocess is right module to use here, but I believe the >> recommended method would be: >> >> subprocess.call(gitcmd... >> >> According to: http://docs.python.org/library/subprocess.html >> >>> >>> branches = [] >>> >>> @@ -708,7 +709,7 @@ def all_branches(context): print "Getting >>> branches from remote repo %s..." % giturl >>> >>> gitcmd = "git ls-remote %s *heads* 2>&1" % (giturl) - tmp = >>> os.popen(gitcmd).read() + tmp = subprocess.Popen(gitcmd, >>> shell=True, stdout=subprocess.PIPE).stdout.read() >>> >>> branches = [] >>> >> >> And here I think subprocess.check_output(...) is preferred. > > That's only in python 2.7 and newer, are distros with python-2.6 > unsupported now? > > I did the same mistake in opkg-utils (patch for it is on yocto > ML). > https://lists.yoctoproject.org/pipermail/yocto/2012-May/009182.html Ah, > thanks for catching that. What is the minimum python requirement? I thought we had something in place to allow for older distributions to work with more modern python syntax. - -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJP0hyPAAoJEKbMaAwKp364hJAIAJ3w30/C6dJoGzCpy14qVZtq 3EouInWZEjIkckztbbkrh9LCJbU8WEiGFd1/yXFlG8TpApF7FPmjY89uDVN7seai Mh9sKzrCIbkS2R1pT8/Ubr7RWL+YGIs4a1hVQbxqZA4PCLPKpxmIe5fDcVBaVm9B k3p328RM0ff5ycos414T4hTcjf3//yI36LESFCBuj133veUwhStwdtDjuz5aMEVj G4TG3SWlPymD0L4hrcMaWyjv7d69BydcKbQm20OOnqVz1BqsS6zlVrCjwPlgq2oe rNqvb96YAWwbReKvPuKXMQmQOaYRubMk9lkXJYrA2+6Z7sV+S5Lu41/yne6pBDY= =9TgZ -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] kernel.py: replace os.popen with subprocess.Popen 2012-06-08 15:39 ` Darren Hart @ 2012-06-12 10:34 ` Richard Purdie 0 siblings, 0 replies; 7+ messages in thread From: Richard Purdie @ 2012-06-12 10:34 UTC (permalink / raw) To: Darren Hart; +Cc: poky On Fri, 2012-06-08 at 08:39 -0700, Darren Hart wrote: > > On 06/08/2012 08:14 AM, Martin Jansa wrote: > > On Fri, Jun 08, 2012 at 08:08:59AM -0700, Darren Hart wrote: > >> And here I think subprocess.check_output(...) is preferred. > > > > That's only in python 2.7 and newer, are distros with python-2.6 > > unsupported now? > > > > I did the same mistake in opkg-utils (patch for it is on yocto > > ML). > > https://lists.yoctoproject.org/pipermail/yocto/2012-May/009182.html > > Ah, > > > thanks for catching that. What is the minimum python requirement? > > I thought we had something in place to allow for older distributions > to work with more modern python syntax. We have the option of the external python tarball but we only resort to that for really old systems. Our minimum python version is currently 2.6 and whilst there are some benefits from 2.7 (such as the process stuff), we've not seen enough to warrant switching at this point. We have workarounds in place for the process pieces. Cheers, Richard ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/1] kernel.py: replace os.popen with subprocess.Popen 2012-06-01 8:51 [PATCH 0/1] kernel.py: replace os.popen with subprocess.Popen Robert Yang 2012-06-01 8:51 ` [PATCH 1/1] " Robert Yang @ 2012-06-11 17:50 ` Flanagan, Elizabeth 1 sibling, 0 replies; 7+ messages in thread From: Flanagan, Elizabeth @ 2012-06-11 17:50 UTC (permalink / raw) To: Robert Yang; +Cc: poky On Fri, Jun 1, 2012 at 1:51 AM, Robert Yang <liezhi.yang@windriver.com> wrote: > Note: This is only for yocto, not for oe-core, since oe-core doesn't > have scripts/lib/bsp/kernel.py. > > // Robert > > The following changes since commit de4cdfd6bc1280ac7ac0559b87734d26294ef773: > > documentation/kernel-manual/kernel-how-to.xml: Updated to kernel 3.4 (2012-05-31 21:16:55 +0100) > > are available in the git repository at: > git://git.pokylinux.org/poky-contrib robert/kernel_py > http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/kernel_py > > Robert Yang (1): > kernel.py: replace os.popen with subprocess.Popen > > scripts/lib/bsp/kernel.py | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky Merged into Poky Thanks -b -- Elizabeth Flanagan Yocto Project Build and Release ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-06-12 10:34 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-06-01 8:51 [PATCH 0/1] kernel.py: replace os.popen with subprocess.Popen Robert Yang 2012-06-01 8:51 ` [PATCH 1/1] " Robert Yang 2012-06-08 15:08 ` Darren Hart 2012-06-08 15:14 ` Martin Jansa 2012-06-08 15:39 ` Darren Hart 2012-06-12 10:34 ` Richard Purdie 2012-06-11 17:50 ` [PATCH 0/1] " Flanagan, Elizabeth
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.