All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: bryan.wu@analog.com, jack.lan@freescale.com,
	nick.spence@freescale.com, dwmw2@infradead.org,
	linux-mtd@lists.infradead.org, scottwood@freescale.com,
	Dipen.Dudhat@freescale.com, tglx@linutronix.de,
	tie-fei.zang@freescale.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] MTD: nand: add return value for write_page() function in structure of nand_ecc_ctrl.
Date: Tue, 12 Jun 2012 13:49:36 +0300	[thread overview]
Message-ID: <1339498176.2401.27.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1339153855-3761-1-git-send-email-josh.wu@atmel.com>

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

On Fri, 2012-06-08 at 19:10 +0800, Josh Wu wrote:
>  /**
> + * nand_write_page_none - [INTERN] raw page writen function with return value
> + * @mtd: mtd info structure
> + * @chip: nand chip info structure
> + * @buf: data buffer
> + * @oob_required: must write chip->oob_poi to OOB
> + */
> +static inline int nand_write_page_none(struct mtd_info *mtd,
> +                               struct nand_chip *chip,
> +                               const uint8_t *buf, int oob_required)
> +{
> +       nand_write_page_raw(mtd, chip, buf, oob_required);
> +
> +       return 0;
> +} 

Thanks!

Would you please also make the wrtite_page_raw call-back return an error
code - it is just strange to change '->write_page' and avoid changing
'->write_page_raw'...

P.S. Not sure we still want these baroque header comments, but this is
just a side note and separate issue.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] MTD: nand: add return value for write_page() function in structure of nand_ecc_ctrl.
Date: Tue, 12 Jun 2012 13:49:36 +0300	[thread overview]
Message-ID: <1339498176.2401.27.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1339153855-3761-1-git-send-email-josh.wu@atmel.com>

On Fri, 2012-06-08 at 19:10 +0800, Josh Wu wrote:
>  /**
> + * nand_write_page_none - [INTERN] raw page writen function with return value
> + * @mtd: mtd info structure
> + * @chip: nand chip info structure
> + * @buf: data buffer
> + * @oob_required: must write chip->oob_poi to OOB
> + */
> +static inline int nand_write_page_none(struct mtd_info *mtd,
> +                               struct nand_chip *chip,
> +                               const uint8_t *buf, int oob_required)
> +{
> +       nand_write_page_raw(mtd, chip, buf, oob_required);
> +
> +       return 0;
> +} 

Thanks!

Would you please also make the wrtite_page_raw call-back return an error
code - it is just strange to change '->write_page' and avoid changing
'->write_page_raw'...

P.S. Not sure we still want these baroque header comments, but this is
just a side note and separate issue.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120612/e17906fc/attachment.sig>

  reply	other threads:[~2012-06-12 10:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 11:10 [RFC PATCH] MTD: nand: add return value for write_page() function in structure of nand_ecc_ctrl Josh Wu
2012-06-08 11:10 ` Josh Wu
2012-06-12 10:49 ` Artem Bityutskiy [this message]
2012-06-12 10:49   ` Artem Bityutskiy
2012-06-12 11:06   ` Josh Wu
2012-06-12 11:06     ` Josh Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339498176.2401.27.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=Dipen.Dudhat@freescale.com \
    --cc=bryan.wu@analog.com \
    --cc=dwmw2@infradead.org \
    --cc=jack.lan@freescale.com \
    --cc=josh.wu@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nick.spence@freescale.com \
    --cc=scottwood@freescale.com \
    --cc=tglx@linutronix.de \
    --cc=tie-fei.zang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.