From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf, x86: Enable PDIR precise instruction profiling on IvyBridge
Date: Wed, 13 Jun 2012 23:43:58 +0200 [thread overview]
Message-ID: <1339623838.8980.71.camel@twins> (raw)
In-Reply-To: <20120613213651.GD32604@tassilo.jf.intel.com>
On Wed, 2012-06-13 at 14:36 -0700, Andi Kleen wrote:
> > This patch is just wrong on too many levels.. where do you want me to
> > start. Lets go with the restriction you mention is lifted, the SDM
> > doesn't mention this,
>
> The SDM is wrong. The restriction is Sandy Bridge only.
It would be good to mention this -- at the very least until the SDM is
revised.
> >nor does the patch actually lift it.
>
> Why not? It works for me on a Ivy Bridge.
I'm very sure you didn't test it properly then. Clearly you need a hint:
struct event_constraint intel_snb_pebs_event_constraints[] = {
INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PRECDIST */
Is still in effect, isn't it..
next prev parent reply other threads:[~2012-06-13 21:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 19:20 [PATCH 1/2] perf, x86: Add basic Ivy Bridge support v3 Andi Kleen
2012-06-13 19:20 ` [PATCH 2/2] perf, x86: Enable PDIR precise instruction profiling on IvyBridge Andi Kleen
2012-06-13 21:26 ` Peter Zijlstra
2012-06-13 21:36 ` Andi Kleen
2012-06-13 21:43 ` Peter Zijlstra [this message]
2012-06-13 21:54 ` Andi Kleen
2012-06-13 21:58 ` Peter Zijlstra
2012-06-13 22:04 ` Andi Kleen
2012-06-13 21:24 ` [PATCH 1/2] perf, x86: Add basic Ivy Bridge support v3 Peter Zijlstra
2012-06-14 13:41 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2012-06-08 21:45 Updated Ivybridge perf patchkit for tip perf/core Andi Kleen
2012-06-08 21:45 ` [PATCH 2/2] perf, x86: Enable PDIR precise instruction profiling on IvyBridge Andi Kleen
2012-06-07 23:18 [PATCH 1/2] perf, x86: Add basic Ivy Bridge support v2 Andi Kleen
2012-06-07 23:18 ` [PATCH 2/2] perf, x86: Enable PDIR precise instruction profiling on IvyBridge Andi Kleen
2012-06-07 22:29 [PATCH 1/2] perf, x86: Add basic Ivy Bridge support Andi Kleen
2012-06-07 22:29 ` [PATCH 2/2] perf, x86: Enable PDIR precise instruction profiling on IvyBridge Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339623838.8980.71.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.