From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@elte.hu, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] perf, x86: Add basic Ivy Bridge support v3
Date: Thu, 14 Jun 2012 15:41:42 +0200 [thread overview]
Message-ID: <20120614134142.GI11413@one.firstfloor.org> (raw)
In-Reply-To: <1339622672.8980.61.camel@twins>
> I really don't see the point of this patch,.. it is in fact using the
> SandyBridge events..
It needs a separate path for the PDIR change and for not doing the PEBS
workaround and for printing Ivy instead of Sandy. I had it originally merged in v1 with a
goto, but Ingo thought it was obfuscated, so it became a separate block.
If you disagree with Ingo please take it up with him.
> also you appear to have removed the backend stalls
> which per SDM (may 2012) table 19-2 would be the very same.
Stephane said that event doesn't exist anymore and I agree with him.
You cannot just base it on the SDM, it's SDM plus whatever is currently
known.
Besides they are misleading and wrong in any case.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2012-06-14 13:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 19:20 [PATCH 1/2] perf, x86: Add basic Ivy Bridge support v3 Andi Kleen
2012-06-13 19:20 ` [PATCH 2/2] perf, x86: Enable PDIR precise instruction profiling on IvyBridge Andi Kleen
2012-06-13 21:26 ` Peter Zijlstra
2012-06-13 21:36 ` Andi Kleen
2012-06-13 21:43 ` Peter Zijlstra
2012-06-13 21:54 ` Andi Kleen
2012-06-13 21:58 ` Peter Zijlstra
2012-06-13 22:04 ` Andi Kleen
2012-06-13 21:24 ` [PATCH 1/2] perf, x86: Add basic Ivy Bridge support v3 Peter Zijlstra
2012-06-14 13:41 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614134142.GI11413@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.