Parse errors introduce by qt4 python->shell style functions

Parse errors introduce by qt4 python->shell style functions

[Anders Darander]

Hi,

I recently started to look at updating our internal repos using the
latest denzil updates.

However, this introduced parse errors for us. We got a bbappend for
qt4-embedded, which includes a number of lines like:

QT_CONFIG_FLAGS := "${@oe_filter_out('-plugin-gfx-transformed', 
'${QT_CONFIG_FLAGS}', d)}"

(this is to remove lots of features, both size-wise and to reduce build
time).

This work fine up to the original denzil release. Now I've run a bisect,
and found that our problems was introduced by "qt4: move functions from
python to shell style", commit id:
98cb2efe4e9f3092d531c9fc809406c3ef559725.

After this commit, we get errors like:
$ bitbake core-image-sato -eLoading cache: 100%
|###################################################| ETA:  00:00:00
Loaded 1109 entries from dependency cache.
ERROR: Failure expanding variable QT_CONFIG_FLAGS[:=], expression was
${@oe_filter_out('-plugin-gfx-transformed', '      -embedded ${QT_ARCH}
-qtlibinfix E     -plugin-gfx-transformed -plugin-gfx-qvfb
-plugin-gfx-vnc -plugin-gfx-directfb     -plugin-mouse-tslib
-qt-mouse-pc -qt-mouse-qvfb -qt-mouse-linuxinput     -qt-kbd-tty
-DQT_KEYPAD_NAVIGATION      -release -no-cups -reduce-relocations
-shared -no-nas-sound -no-nis                     -system-libjpeg
-system-libpng -system-libtiff -system-zlib                     -no-pch
-qdbus -stl -glib -phonon -webkit                     -xmlpatterns
-no-rpath -qt3support -silent                     --enable-pulseaudio
-no-sql-ibase -no-sql-mysql -no-sql-psql -no-sql-odbc -plugin-sql-sqlite
-no-accessibility -no-sm                        -exceptions ', d)} which
triggered exception SyntaxError: EOL while scanning string literal
(QT_CONFIG_FLAGS[:=], line 1)
ERROR: Command execution failed: Exited with 1

Summary: There were 2 ERROR messages shown, returning a non-zero exit
code.

The change from python to shell style functions seems to require some
adaption of our bbappends, which I can't find...

Any ideas?

Thanks in advance!

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB

Re: Parse errors introduce by qt4 python->shell style functions

[Richard Purdie]

On Sun, 2012-06-17 at 11:03 +0200, Anders Darander wrote:
> Hi,
> 
> I recently started to look at updating our internal repos using the
> latest denzil updates.
> 
> However, this introduced parse errors for us. We got a bbappend for
> qt4-embedded, which includes a number of lines like:
> 
> QT_CONFIG_FLAGS := "${@oe_filter_out('-plugin-gfx-transformed', 
> '${QT_CONFIG_FLAGS}', d)}"
> 
> (this is to remove lots of features, both size-wise and to reduce build
> time).
> 
> This work fine up to the original denzil release. Now I've run a bisect,
> and found that our problems was introduced by "qt4: move functions from
> python to shell style", commit id:
> 98cb2efe4e9f3092d531c9fc809406c3ef559725.
> 
> After this commit, we get errors like:
> $ bitbake core-image-sato -eLoading cache: 100%
> |###################################################| ETA:  00:00:00
> Loaded 1109 entries from dependency cache.
> ERROR: Failure expanding variable QT_CONFIG_FLAGS[:=], expression was
> ${@oe_filter_out('-plugin-gfx-transformed', '      -embedded ${QT_ARCH}

Where is QT_ARCH coming from?

Looking at the way the code now works, I have a suspicion that we should
change that to $QT_ARCH and that might fix your problem. I'm just
guessing though.

Cheers,

Richard

Re: Parse errors introduce by qt4 python->shell style functions

[Anders Darander]

* Richard Purdie <richard.purdie@linuxfoundation.org> [120617 11:23]:
> On Sun, 2012-06-17 at 11:03 +0200, Anders Darander wrote:
> > I recently started to look at updating our internal repos using the
> > latest denzil updates.

> > However, this introduced parse errors for us. We got a bbappend for
> > qt4-embedded, which includes a number of lines like:

> > QT_CONFIG_FLAGS := "${@oe_filter_out('-plugin-gfx-transformed', 
> > '${QT_CONFIG_FLAGS}', d)}"

> > (this is to remove lots of features, both size-wise and to reduce build
> > time).

> > This work fine up to the original denzil release. Now I've run a bisect,
> > and found that our problems was introduced by "qt4: move functions from
> > python to shell style", commit id:
> > 98cb2efe4e9f3092d531c9fc809406c3ef559725.

> > After this commit, we get errors like:
> > $ bitbake core-image-sato -eLoading cache: 100%
> > |###################################################| ETA:  00:00:00
> > Loaded 1109 entries from dependency cache.
> > ERROR: Failure expanding variable QT_CONFIG_FLAGS[:=], expression was
> > ${@oe_filter_out('-plugin-gfx-transformed', '      -embedded ${QT_ARCH}

> Where is QT_ARCH coming from?

It comes from qt4_arch.inc along the rest of qt4. 

qt4-embedded.inc is adding this QT_ARCH to QT_CONFIG_FLAGS.

I probably should have mentioned that during bisecting, I was only using
oe-core (and bitbake 1.15.2), no other layers/distros. And I copied my
oe_filter_out line to the end of qt4-embedded_4.7.4.bb, all to make it
easier for you (or someone else) to reproduce, and also to remove the
possibillity of errors in my local layers and meta-oe.

> Looking at the way the code now works, I have a suspicion that we should
> change that to $QT_ARCH and that might fix your problem. I'm just
> guessing though.

Thanks, that solved the problem. Patch on it's way.

I could have sworn that I had tried that... but obviously not.

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB